Fix lint errors #515
Merged
Fix lint errors #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceninja
reviewed
Mar 4, 2020
| // TODO: These font styles are temporary, for demo purposes | ||
| font-family: inherit; | ||
| font-size: 18px; | ||
| transition: transform motion.$speed-quick motion.$ease-out; |
There was a problem hiding this comment.
Is transition temporary? If not, I'd recommend changing the temporary comment to a footnote style to make it clearer which lines it applies to.
There was a problem hiding this comment.
Everything in demo is temporary.
There was a problem hiding this comment.
If it's temporary, then you're good to go. :)
There was a problem hiding this comment.
I just wanted to make sure that rule moving below the comment wasn't inadvertently confusing.
spaceninja
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes lint errors introduced between #506 and #507 being merged.
Testing
Verify status checks pass.