-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amtool #271
Amtool #271
Conversation
zloeber
commented
Nov 12, 2019
- Adds amtool per [amtool] add package #149
/codefresh run apk |
/codefresh run docker |
/codefresh run apk |
/codefresh run docker |
@zloeber build is failing:
This is usually because package depends on To debug, this is what I would run:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Sorry, I'm looking into this and the build error is because the test of the executable is actually trying to run the tar.gz file for reasons I've yet to discern. I made some minor changes to fall more in line with what other packages are doing for instances where the repo name does not align with the app being installed but cannot seem to get the build to test properly regardless. I suppose the closest model app would be fzf (in theory at least). I'll keep digging into this when I can but will take any more hints you have to give :) |
Aha, ok I will take a look. Don’t spend too much time ;) Maybe look at where we define a “prepare*” target I ran into this the other day, but forget which package. |
I believe that the auto-label tasks are failing the build at this point. I haven't quite figured out the auto-label goals yet but I get make errors about the use of : and :: on the same task (I worked around the local build issues by changing the tasks but wasn't certain what else would be broken upstream because of it). In another pull request of more questionable value (feature/package_helpers) I left the makefile changes for auto-label though. Thanks |
re-run |
Ignore all the |
README.md
Outdated
@@ -477,7 +491,6 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply | |||
[email]: https://cpco.io/email?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=email | |||
[commercial_support]: https://cpco.io/commercial-support?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=commercial_support | |||
[we_love_open_source]: https://cpco.io/we-love-open-source?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=we_love_open_source | |||
[terraform_modules]: https://cpco.io/terraform-modules?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=terraform_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting this line is failing the linting process. Did you delete it manually? The README.md
is generated dynamically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly not certain how that happened. Sorry I'm having such a hard time with this one.
Just one thing... The Please rebuild the
There might be a lot of changes in the Sorry for the inconvenience! |
/codefresh run apk |
/codefresh run docker |
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * pgmetrics: add package * pgmetrics: add package
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * cfssl: Add package * cfssl: Add package
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * k9s: add package * k9s: add package
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * popeye: add package Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * katafygio: Add package Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * [k3d]: Add Package Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * pack: Add package * pack: Add package * update: fix merge conflicts * Update README.md Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com> Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * popeye: add package * argocd: Add package * argocd: version update * update: fix argocd apk build * update: fix argocd apk build Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>