Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amtool #271

Merged
merged 19 commits into from
Nov 29, 2019
Merged

Amtool #271

merged 19 commits into from
Nov 29, 2019

Conversation

zloeber
Copy link
Contributor

@zloeber zloeber commented Nov 12, 2019

@osterman
Copy link
Member

/codefresh run apk

@osterman
Copy link
Member

/codefresh run docker

@osterman
Copy link
Member

/codefresh run apk

@osterman
Copy link
Member

/codefresh run docker

@osterman
Copy link
Member

osterman commented Nov 15, 2019

@zloeber build is failing:

/bin/bash: /codefresh/volume/packages/tmp/build.mjnPAk/src/amtool: cannot execute binary file: Exec format e
rror   

This is usually because package depends on libc6-compat

To debug, this is what I would run:

make docker/build/apk/shell
make -C vendor/amtool apk

Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@zloeber zloeber requested a review from a team as a code owner November 24, 2019 18:58
@zloeber
Copy link
Contributor Author

zloeber commented Nov 24, 2019

Sorry, I'm looking into this and the build error is because the test of the executable is actually trying to run the tar.gz file for reasons I've yet to discern. I made some minor changes to fall more in line with what other packages are doing for instances where the repo name does not align with the app being installed but cannot seem to get the build to test properly regardless. I suppose the closest model app would be fzf (in theory at least). I'll keep digging into this when I can but will take any more hints you have to give :)

@osterman
Copy link
Member

Aha, ok I will take a look. Don’t spend too much time ;)

Maybe look at where we define a “prepare*” target

I ran into this the other day, but forget which package.

@zloeber
Copy link
Contributor Author

zloeber commented Nov 26, 2019

I believe that the auto-label tasks are failing the build at this point. I haven't quite figured out the auto-label goals yet but I get make errors about the use of : and :: on the same task (I worked around the local build issues by changing the tasks but wasn't certain what else would be broken upstream because of it). In another pull request of more questionable value (feature/package_helpers) I left the makefile changes for auto-label though.

Thanks

@osterman
Copy link
Member

I haven't quite figured out the auto-label goals yet but I get make errors about the use of : and :: on the same tas

re-run make init as this was fixed upstream in the build-harness cloudposse/build-harness#187

@osterman
Copy link
Member

Ignore all the auto-* failures - those won't run on forks due to github security model

README.md Outdated
@@ -477,7 +491,6 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply
[email]: https://cpco.io/email?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=email
[commercial_support]: https://cpco.io/commercial-support?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=commercial_support
[we_love_open_source]: https://cpco.io/we-love-open-source?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=we_love_open_source
[terraform_modules]: https://cpco.io/terraform-modules?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/packages&utm_content=terraform_modules
Copy link
Member

@osterman osterman Nov 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this line is failing the linting process. Did you delete it manually? The README.md is generated dynamically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly not certain how that happened. Sorry I'm having such a hard time with this one.

@osterman
Copy link
Member

Just one thing... The README.md is generated from the README.yaml. Make all your changes to the README.yaml, then rebuild.

Please rebuild the README.md by running the following commands:

make init
make readme/deps
make readme

There might be a lot of changes in the README.md as a result. That's okay!

Sorry for the inconvenience!

@osterman
Copy link
Member

/codefresh run apk

@osterman
Copy link
Member

/codefresh run docker

@osterman osterman merged commit 7e44b82 into cloudposse:master Nov 29, 2019
@zloeber zloeber deleted the amtool branch November 30, 2019 02:53
osterman pushed a commit that referenced this pull request Dec 9, 2019
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* pgmetrics: add package

* pgmetrics: add package
osterman pushed a commit that referenced this pull request Dec 10, 2019
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* cfssl: Add package

* cfssl: Add package
osterman pushed a commit that referenced this pull request Dec 12, 2019
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* k9s: add package

* k9s: add package
osterman added a commit that referenced this pull request Dec 26, 2019
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* popeye: add package

Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
osterman added a commit that referenced this pull request Dec 27, 2019
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* katafygio: Add package

Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
osterman added a commit that referenced this pull request Dec 27, 2019
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* [k3d]: Add Package

Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
osterman added a commit that referenced this pull request Jan 17, 2020
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* pack: Add package

* pack: Add package

* update: fix merge conflicts

* Update README.md

Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
osterman added a commit that referenced this pull request Jan 22, 2020
* Rebuilt README.md (#270)

* Automatically update README nightly (#268)

* Automatically update README nightly

* fix triggers

* add name

* fix syntax

* add labels

* Fix example (#272)

* Update README.md (#273)

* Kind (#266)

* update: add kind

* update: minor pathing fixes to makefile inclusion documentation for a functional example

* update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* update: minor readme fixes

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.yaml

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

* Update README.md (#274)

* Automated Package Updates (#275)

* update packages

* Fix vendor packages after updates

* Restore Makefile

* fix tarball

* reset release

* Update actions (#276)

* Update actions

* refactor auto-lable

* remove dup

* Update README.md (#278)

* update packages (#279)

* Automated Package Updates (#280)

* update packages

* fix sops download url

* Automated Package Updates (#281)

* update packages

* Fix pandoc url

* Rollback release

* update packages (#282)

* feature: kubectl plugin manager (krew) app (#286)

* [jx] add tool (#287)

* [jx] add tool

* fix: install as tarball, not binary

* [rancher] Add Package (#288)

* update packages (#285)

* Amtool (#271)

* update: addition of amtool

* update: addition of amtool

* update: amtool build fixes

* update: amtool build fixes

* update: amtool apk build

* fix: add amtool to auto-label

* fix: Makefile fix?

* fix: Makefile auto-label

* update: readme update

* update: auto-label space update

* Automated Package Updates (#289)

* update packages

* update packages

* update packages

* update packages (#290)

* popeye: add package

* argocd: Add package

* argocd: version update

* update: fix argocd apk build

* update: fix argocd apk build

Co-authored-by: Erik Osterman <erik@cloudposse.com>
Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants