-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: kubectl plugin manager (krew) app #286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/codefresh run apk |
/codefresh run docker |
osterman
approved these changes
Nov 28, 2019
osterman
reviewed
Nov 28, 2019
include ../../tasks/Makefile.package | ||
include ../../tasks/Makefile.apk | ||
|
||
## Package specific install code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, you could write:
Suggested change
## Package specific install code | |
## Package specific install code | |
install: KREW_ROOT=$(INSTALL_PATH) |
Then you can get rid of all the &&
stuff because make automatically exits non-zero if any of the commands fail.
osterman
pushed a commit
that referenced
this pull request
Dec 9, 2019
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * pgmetrics: add package * pgmetrics: add package
osterman
pushed a commit
that referenced
this pull request
Dec 10, 2019
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * cfssl: Add package * cfssl: Add package
osterman
pushed a commit
that referenced
this pull request
Dec 12, 2019
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * k9s: add package * k9s: add package
osterman
added a commit
that referenced
this pull request
Dec 26, 2019
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * popeye: add package Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
osterman
added a commit
that referenced
this pull request
Dec 27, 2019
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * katafygio: Add package Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
osterman
added a commit
that referenced
this pull request
Dec 27, 2019
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * [k3d]: Add Package Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
osterman
added a commit
that referenced
this pull request
Jan 17, 2020
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * pack: Add package * pack: Add package * update: fix merge conflicts * Update README.md Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com> Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
osterman
added a commit
that referenced
this pull request
Jan 22, 2020
* Rebuilt README.md (#270) * Automatically update README nightly (#268) * Automatically update README nightly * fix triggers * add name * fix syntax * add labels * Fix example (#272) * Update README.md (#273) * Kind (#266) * update: add kind * update: minor pathing fixes to makefile inclusion documentation for a functional example * update: Additional notes for adding new packages, minor wording fix for description of fetch package, update of readme * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md Co-Authored-By: Erik Osterman <erik@cloudposse.com> * update: minor readme fixes * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.yaml Co-Authored-By: Erik Osterman <erik@cloudposse.com> * Update README.md (#274) * Automated Package Updates (#275) * update packages * Fix vendor packages after updates * Restore Makefile * fix tarball * reset release * Update actions (#276) * Update actions * refactor auto-lable * remove dup * Update README.md (#278) * update packages (#279) * Automated Package Updates (#280) * update packages * fix sops download url * Automated Package Updates (#281) * update packages * Fix pandoc url * Rollback release * update packages (#282) * feature: kubectl plugin manager (krew) app (#286) * [jx] add tool (#287) * [jx] add tool * fix: install as tarball, not binary * [rancher] Add Package (#288) * update packages (#285) * Amtool (#271) * update: addition of amtool * update: addition of amtool * update: amtool build fixes * update: amtool build fixes * update: amtool apk build * fix: add amtool to auto-label * fix: Makefile fix? * fix: Makefile auto-label * update: readme update * update: auto-label space update * Automated Package Updates (#289) * update packages * update packages * update packages * update packages (#290) * popeye: add package * argocd: Add package * argocd: version update * update: fix argocd apk build * update: fix argocd apk build Co-authored-by: Erik Osterman <erik@cloudposse.com> Co-authored-by: Cloud Posse Bot (CI/CD) <ops@cloudposse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why