feat: Implement plugin Read #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
- Coverage 48.03% 47.79% -0.24%
==========================================
Files 77 77
Lines 7455 7492 +37
==========================================
Hits 3581 3581
- Misses 3543 3580 +37
Partials 331 331
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
Jun 30, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
LGTM. I think go.mod conflict and lint fixes are needed.
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 30, 2023
🤖 I have created a release *beep* *boop* --- ## [4.4.0-rc1](v4.3.1-rc1...v4.4.0-rc1) (2023-06-30) ### Features * Implement plugin Read ([#1027](#1027)) ([09fb4ce](09fb4ce)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.4.0 ([#1005](#1005)) ([40f1c77](40f1c77)) * Update to plugin-pb v1.5.0 ([#1026](#1026)) ([abe2557](abe2557)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1026 should be merged first