fix(writers): StreamingBatchWriter hangs with non-append mode #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1131 +/- ##
==========================================
+ Coverage 47.67% 47.91% +0.23%
==========================================
Files 85 85
Lines 7805 7808 +3
==========================================
+ Hits 3721 3741 +20
+ Misses 3746 3730 -16
+ Partials 338 337 -1
☔ View full report in Codecov by Sentry. |
candiduslynx
approved these changes
Aug 4, 2023
bbernays
reviewed
Aug 7, 2023
Comment on lines
+25
to
+27
| // nolint:revive | ||
| for range ch { | ||
| } |
2 tasks
disq
changed the title
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- ## [4.2.6](v4.2.5...v4.2.6) (2023-08-08) ### Bug Fixes * **deps:** Update github.com/cloudquery/arrow/go/v13 digest to f53878d ([#1132](#1132)) ([0c47570](0c47570)) * **writers:** StreamingBatchWriter hangs with non-append mode ([#1131](#1131)) ([806c85d](806c85d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the hang issue with non-append mode when a dest is using
UnimplementedDeleteStale.We're noticing this now because of feat: Make PostgreSQL destination use streaming batch writer (writes per table) cloudquery#12765, as other plugins using this writer (file based plugins) don't support migration operations.
Also makes it so that you don't need to call Close() on plugin deinit (but it could still be a good idea if Write was interrupted)