fix: Remove access to parent tests in test suite #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
requested review from
erezrokah,
hermanschaaf and
yevgenypats
as code owners
hermanschaaf
approved these changes
Jan 31, 2024
⏱️ Benchmark results
|
Contributor
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
Do we have an option to switch to a proper test suites?
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
🤖 I have created a release *beep* *boop* --- ## [4.29.0](v4.28.0...v4.29.0) (2024-01-31) ### Features * Introduce `PrimaryKeyComponent` ([#1491](#1491)) ([ae4a26e](ae4a26e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.7.1 ([#1499](#1499)) ([165be4d](165be4d)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.16.7 ([#1500](#1500)) ([2b98dab](2b98dab)) * Remove access to parent tests in test suite ([#1497](#1497)) ([63e95e7](63e95e7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Member
Author
|
@candiduslynx wdym? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving
*testing.Tinside theSuiteto use it later in sub-tests results in this error if we have a failed test:We shouldn't get this error.
Other parts of the test suite return
error(signature isfunc (s *WriterTestSuite) testName(context.Context) error) and we do a simplet.Fatalin the main test body, but for DeleteStale tests we usetestify/requireinside the test so we need to access*testing.T.