fix: Tests #281
Merged
fix: Tests #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now, we only tested that the first resource has values in all columns. A more correct test tests that every column has at least one value in every column. This is important to avoid failures that are based just on ordering of resources (especially now that we added more concurrency to resolving). Important for tests with more than one resource.
yevgenypats
approved these changes
Oct 11, 2022
hermanschaaf
pushed a commit
that referenced
this pull request
Oct 11, 2022
🤖 I have created a release *beep* *boop* --- ## [0.13.4](v0.13.3...v0.13.4) (2022-10-11) ### Bug Fixes * Tests ([#281](#281)) ([983e57b](983e57b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now, we only tested that the first resource has values in all columns. A more correct test tests that every column has at least one value in every column. This is important to avoid failures that are based just on ordering of resources (especially now that we added more concurrency to resolving). Important for tests with more than one resource.
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)