fix: Disallow null character in strings per utf8 spec #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with b1baab6
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
- Coverage 46.73% 46.71% -0.02%
==========================================
Files 76 76
Lines 7830 7832 +2
==========================================
Hits 3659 3659
- Misses 3680 3682 +2
Partials 491 491
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
erezrokah
approved these changes
Apr 19, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
🤖 I have created a release *beep* *boop* --- ## [2.3.2](v2.3.1...v2.3.2) (2023-04-19) ### Bug Fixes * Arrow Retain and Release fixes ([#795](#795)) ([a893db6](a893db6)) * Disallow null character in strings per utf8 spec ([#797](#797)) ([591502f](591502f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve bunch of issues that we have with NullValues and StripNulls logic propagated to all our destination plugins. Apparently Valid utf8 string can't have null values in the middle of the string so we should just strip those in our type system (it can have at the end or the start but I suggest actually stripping those down as well as it's really unnecessary as far as I know and it exist prob for some archaic reason like sending a string over the wire without any additional encoding/protocol, which we have via arrow).
Once we move sources to arrow we will add the validation/strip on the source side.