fix: Flatten V2 tables #882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, status.Errorf(codes.InvalidArgument, "failed to unmarshal tables: %v", err) | ||
| } | ||
| tables := TablesV2ToV3(tablesV2) | ||
| tables := TablesV2ToV3(tablesV2).FlattenTables() |
Member
There was a problem hiding this comment.
If this is the destination server, presumably it got the list from the source - so shouldn't the tables already be flattened? I know there can be issues if you flatten a list of tables twice, so we either need to be 100% sure or make FlattenTables idempotent :)
Contributor
Author
There was a problem hiding this comment.
I see. yeah that's a foot gun. not sure what's hapening already. ok let's make it idempotent.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
+ Coverage 47.29% 47.37% +0.07%
==========================================
Files 55 55
Lines 5034 5041 +7
==========================================
+ Hits 2381 2388 +7
Misses 2401 2401
Partials 252 252
☔ View full report in Codecov by Sentry. |
⏱️ Benchmark resultsComparing with 7d749b1
|
hermanschaaf
approved these changes
May 16, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 16, 2023
🤖 I have created a release *beep* *boop* --- ## [3.5.1](v3.5.0...v3.5.1) (2023-05-16) ### Bug Fixes * Flatten V2 tables ([#882](#882)) ([28706f1](28706f1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more footgun in old protocol.