fix(tables): Flatten stripping relations #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark results
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
==========================================
+ Coverage 47.37% 47.38% +0.01%
==========================================
Files 55 55
Lines 5041 5044 +3
==========================================
+ Hits 2388 2390 +2
- Misses 2401 2402 +1
Partials 252 252
☔ View full report in Codecov by Sentry. |
disq
approved these changes
May 16, 2023
candiduslynx
commented
May 16, 2023
Contributor
Author
candiduslynx
left a comment
candiduslynx
left a comment
There was a problem hiding this comment.
@yevgenypats now FlattenTables will strip the relations info, so, if the code calls flattening it has to treat the tables as a flat list instead of forest-like structure
yevgenypats
suggested changes
May 16, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
looks good. one nit.
candiduslynx
force-pushed
the
feat/flatten-idemp
branch
from
4363571 to
7fd6b1d
Compare
yevgenypats
approved these changes
May 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 18, 2023
🤖 I have created a release *beep* *boop* --- ## [3.5.2](v3.5.1...v3.5.2) (2023-05-18) ### Bug Fixes * **arrow:** `schema.Table` <-> `arrow.Schema` conversion ([#886](#886)) ([61d98c9](61d98c9)) * **destination:** Don't duplicate tables to be removed ([#886](#886)) ([61d98c9](61d98c9)) * **tables:** Flatten stripping relations ([#884](#884)) ([e890385](e890385)) * **testing:** CQ Parent ID column should not be NotNull ([#887](#887)) ([f4aa5bc](f4aa5bc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.