fix: Add null-row case for append-only tests #889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
commented
May 19, 2023
| c.Name != CqSourceNameColumn.Name && | ||
| c.Name != CqSyncTimeColumn.Name && | ||
| c.Name != CqIDColumn.Name && | ||
| c.Name != CqParentIDColumn.Name { |
Member
Author
There was a problem hiding this comment.
This wasn't a bug as such, but I don't see a reason to prevent CQParentIDColumn from being set to null, as in many cases it will be null
Contributor
There was a problem hiding this comment.
How a parentIDColumn can be null?
Member
Author
There was a problem hiding this comment.
For all top-level tables
⏱️ Benchmark resultsComparing with 0dabfeb
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
=======================================
Coverage 47.32% 47.33%
=======================================
Files 55 55
Lines 5050 5049 -1
=======================================
Hits 2390 2390
+ Misses 2408 2407 -1
Partials 252 252
☔ View full report in Codecov by Sentry. |
candiduslynx
approved these changes
May 19, 2023
yevgenypats
approved these changes
May 19, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 21, 2023
🤖 I have created a release *beep* *boop* --- ## [3.6.0](v3.5.2...v3.6.0) (2023-05-21) ### Features * Add precision options for dest testing ([#893](#893)) ([faacca6](faacca6)) * Refactor test options and allow skipping of nulls in lists ([#892](#892)) ([bc3c251](bc3c251)) ### Bug Fixes * Add null-row case for append-only tests ([#889](#889)) ([6967929](6967929)) * Tighter Arrow test cases ([#891](#891)) ([c7f2546](c7f2546)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.