feat: Refactor test options and allow skipping of nulls in lists #892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ Benchmark resultsComparing with 6967929
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
- Coverage 47.33% 47.19% -0.14%
==========================================
Files 55 55
Lines 5049 5013 -36
==========================================
- Hits 2390 2366 -24
+ Misses 2407 2397 -10
+ Partials 252 250 -2
☔ View full report in Codecov by Sentry. |
yevgenypats
approved these changes
May 20, 2023
Contributor
yevgenypats
left a comment
yevgenypats
left a comment
There was a problem hiding this comment.
Nice. Need that also for mongo but for different option - changing the timestamp precision (mongodb only supports milliseconds).
kodiakhq bot
pushed a commit
that referenced
this pull request
May 21, 2023
🤖 I have created a release *beep* *boop* --- ## [3.6.0](v3.5.2...v3.6.0) (2023-05-21) ### Features * Add precision options for dest testing ([#893](#893)) ([faacca6](faacca6)) * Refactor test options and allow skipping of nulls in lists ([#892](#892)) ([bc3c251](bc3c251)) ### Bug Fixes * Add null-row case for append-only tests ([#889](#889)) ([6967929](6967929)) * Tighter Arrow test cases ([#891](#891)) ([c7f2546](c7f2546)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destination.PluginTestSuiteRunnerwith options from theschemapackage, which is a bit unusual and counter-intuitive, and makes it hard to extend with options that relate specifically to the test suite runner. This changes it so that the options passed in are from thedestinationpackage and passed through to theschemapackage. It's a breaking change, but this functionality hasn't been out for long, will be easy to update, and only affects tests, so I'm hoping users will forgive us for this one.