fix: Use semantic heading for side navigation header #661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We hadn't done this in the past because having an
<h2>persistently before the<h1>in the DOM order would lead to a confusing page hierarchy. But all signals now point to DOM order not being as important as the meaningful hierarchy of the title itself, so... let's do itRelated links, issue #, if available: AWSUI-19376
How has this been tested?
Only a small change in the HTML tag used; can't think of a test case that wouldn't be a brittle one. Also, there should be no visual changes caused by this change either.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.