Skip to content

Conversation

@avinashbot
Copy link
Member

Description

It looks like the .inputs div occupies space even if there's no content to show because of uncollapsable paddings. So the solution is to remove it from the DOM completely so that the expectations match up with reality.

Alternatively, I could have updated the calculations in use-top-navigation, but it's better to have less wasted space :)

Related links, issue #, if available: n/a

How has this been tested?

Local screenshot checks. Compare the "top-navigation/screenshot" page and you'll find that only the final text-only identity should truncate.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@avinashbot avinashbot requested a review from a team as a code owner January 30, 2023 10:09
@avinashbot avinashbot requested review from pan-kot and removed request for a team January 30, 2023 10:09
pan-kot
pan-kot previously approved these changes Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 92.98% // Head: 92.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6abc50d) compared to base (4808e7d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         574      574           
  Lines       16797    16798    +1     
  Branches     4634     4635    +1     
=======================================
+ Hits        15619    15620    +1     
  Misses       1101     1101           
  Partials       77       77           
Impacted Files Coverage Δ
src/top-navigation/internal.tsx 88.75% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avinashbot avinashbot requested a review from pan-kot January 30, 2023 13:19
@avinashbot
Copy link
Member Author

Had to recommit the same change because Codecov was refusing to run last time

@avinashbot avinashbot merged commit b217c7a into main Jan 30, 2023
@avinashbot avinashbot deleted the top-nav-calculation branch January 30, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants