fix: Prevent top navigation identity title from truncating too early #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like the
.inputsdiv occupies space even if there's no content to show because of uncollapsable paddings. So the solution is to remove it from the DOM completely so that the expectations match up with reality.Alternatively, I could have updated the calculations in use-top-navigation, but it's better to have less wasted space :)
Related links, issue #, if available: n/a
How has this been tested?
Local screenshot checks. Compare the "top-navigation/screenshot" page and you'll find that only the final text-only identity should truncate.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.