generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 196
chore: Multi-react version tests setup #3829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3bdbdf
to
db5339b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3829 +/- ##
=======================================
Coverage 97.19% 97.19%
=======================================
Files 844 844
Lines 24559 24559
Branches 8659 8659
=======================================
Hits 23869 23869
Misses 683 683
Partials 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
db5339b
to
6641005
Compare
6641005
to
94101f4
Compare
94101f4
to
dfe9ef6
Compare
8c6ab75
to
5a1f33f
Compare
5a1f33f
to
84f9a61
Compare
84f9a61
to
b6e84a6
Compare
b6e84a6
to
c7ffbb9
Compare
fa4a0d5
to
91ba45b
Compare
91ba45b
to
ac0cb16
Compare
ClaudioGSDB
previously approved these changes
Sep 18, 2025
ac0cb16
to
1050e20
Compare
f679c48
to
582bdb9
Compare
ClaudioGSDB
approved these changes
Sep 22, 2025
Closed
This was referenced Sep 22, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR implements multi-react version setup for the repository, for now supporting versions 16 and 18. It is possible to run either version in the dev mode, the dev pages are deployed for both, and the integ- and motion tests are run for both versions.
The unit tests are only run on v16 for now, as it requires a significant extra effort to make them supported. The a11y tests are only run on v16 for frugality reasons: it is possible to run them on both versions, too, if considered important.
Depends on: cloudscape-design/actions#95, #3832, #3835, #3842, #3851, #3852
In order to release the changes - we need to merge the actions PR first, and then re-deploy rulesets to apply the changes to the required action names ("dry-run / Components motion tests" -> "dry-run / Components motion tests (React 16)" + "dry-run / Components motion tests (React 18)", and the same for integ tests).
How has this been tested?
I did a test run using the react-var actions brach, and with a reverted fix to the table (#3811). Expectedly, all table integ tests for tables without keyboard navigation failed: https://github.com/cloudscape-design/components/actions/runs/17406617638/job/49412605937?pr=3829
Clarification: the tests are running in the dev mode, and the strict mode is active.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.