Skip to content

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Sep 2, 2025

Description

The PR implements multi-react version setup for the repository, for now supporting versions 16 and 18. It is possible to run either version in the dev mode, the dev pages are deployed for both, and the integ- and motion tests are run for both versions.

The unit tests are only run on v16 for now, as it requires a significant extra effort to make them supported. The a11y tests are only run on v16 for frugality reasons: it is possible to run them on both versions, too, if considered important.

Depends on: cloudscape-design/actions#95, #3832, #3835, #3842, #3851, #3852

In order to release the changes - we need to merge the actions PR first, and then re-deploy rulesets to apply the changes to the required action names ("dry-run / Components motion tests" -> "dry-run / Components motion tests (React 16)" + "dry-run / Components motion tests (React 18)", and the same for integ tests).

How has this been tested?

I did a test run using the react-var actions brach, and with a reverted fix to the table (#3811). Expectedly, all table integ tests for tables without keyboard navigation failed: https://github.com/cloudscape-design/components/actions/runs/17406617638/job/49412605937?pr=3829

Clarification: the tests are running in the dev mode, and the strict mode is active.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot changed the title Chore react 18 test pages 2 chore: Multi-react version tests Sep 2, 2025
@pan-kot pan-kot changed the title chore: Multi-react version tests chore: Multi-react version tests setup Sep 2, 2025
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from e3bdbdf to db5339b Compare September 2, 2025 14:24
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (2a71e86) to head (ac0cb16).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3829   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         844      844           
  Lines       24559    24559           
  Branches     8659     8659           
=======================================
  Hits        23869    23869           
  Misses        683      683           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from db5339b to 6641005 Compare September 2, 2025 14:41
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from 6641005 to 94101f4 Compare September 2, 2025 14:59
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from 94101f4 to dfe9ef6 Compare September 2, 2025 15:22
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch 2 times, most recently from 8c6ab75 to 5a1f33f Compare September 2, 2025 17:03
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from 5a1f33f to 84f9a61 Compare September 3, 2025 07:45
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from 84f9a61 to b6e84a6 Compare September 3, 2025 08:25
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from b6e84a6 to c7ffbb9 Compare September 3, 2025 09:15
ClaudioGSDB
ClaudioGSDB previously approved these changes Sep 18, 2025
@pan-kot pan-kot force-pushed the chore-react-18-test-pages-2 branch from f679c48 to 582bdb9 Compare September 22, 2025 09:34
@pan-kot pan-kot mentioned this pull request Sep 22, 2025
@pan-kot pan-kot added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 72b7c04 Sep 22, 2025
63 checks passed
@pan-kot pan-kot deleted the chore-react-18-test-pages-2 branch September 22, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants