Skip to content

Conversation

pan-kot
Copy link
Member

@pan-kot pan-kot commented Sep 23, 2025

Description

The webpack cache name was introduced here: #3829

It is used to ensure the artifacts are not cached between React 16 and 18 runs. However, that caused a problem when running npm run build (bundles pages) followed by npm start (runs dev-server). Both commands use the same webpack config but cannot reuse the cache.

How has this been tested?

  • Running npm run build && npm start now works
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot force-pushed the fix-build-and-start branch from 6ee99db to 89cc620 Compare September 23, 2025 10:25
@pan-kot pan-kot marked this pull request as ready for review September 23, 2025 10:25
@pan-kot pan-kot requested a review from a team as a code owner September 23, 2025 10:25
@pan-kot pan-kot requested review from just-boris and removed request for a team September 23, 2025 10:25
@pan-kot pan-kot enabled auto-merge September 23, 2025 10:34
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (4b02c14) to head (89cc620).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3889   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files         846      846           
  Lines       24592    24592           
  Branches     8680     8680           
=======================================
  Hits        23892    23892           
  Misses        693      693           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit 8c8796c Sep 23, 2025
115 of 118 checks passed
@pan-kot pan-kot deleted the fix-build-and-start branch September 23, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants