Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed value error output in attempt to fix issue #14. #26

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

gwenwhite
Copy link
Contributor

As suggested by Jenny in PR #24, I replayed the changes in commit 2701ce4 onto the current master branch with git cherry-pick as seen below:

git checkout master 
git pull upstream master
git checkout -b value-error-2
git cherry-pick 2701ce4

Hoping this will be a way of getting around some issues I was facing with the other pull request

@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #26 (5aa85e9) into master (adb1764) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           5        5           
  Lines         224      224           
=======================================
  Hits          223      223           
  Misses          1        1           
Impacted Files Coverage Δ
cmeutils/gsd_utils.py 100.00% <100.00%> (ø)

@chrisjonesBSU chrisjonesBSU linked an issue Dec 6, 2021 that may be closed by this pull request
@jennyfothergill
Copy link
Member

Nice work! 🙌

@jennyfothergill jennyfothergill merged commit 608d974 into cmelab:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify error from _validate_inputs
3 participants