Update Unit.php #15
Closed
Update Unit.php #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the degree encoding to html which stops the display of a question mark in some browsers.
|
Please also change the test: https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/blob/master/Cmfcmf/OpenWeatherMap/Util/UnitTest.php#L101 (I know it's located at a very odd position, I will need to work on the tests 😃) |
|
Okay, I'll take a look when I can. I also found that it's located in the forecast.php, but I will find all the places and changed them accordingly. 👍 |
added 3 commits
June 16, 2014 15:33
Another change on the degree c. Made it HTML to stop question marks appearing.
Accidentally removed the C after ° it's now back in.
|
I manually merged your changes and squashed the commits, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the degree encoding to html which stops the display of a question mark in some browsers.