Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Recognition validation for HGCal Tracksters #36712

Merged
merged 24 commits into from
Feb 15, 2022

Conversation

lecriste
Copy link
Contributor

PR description:

This PR introduces a Trackster validation against SimTracksters, labeled PatternRecognition.
The changes expected in the output are:

  • new histograms in the original validation folder (TSToCP_linking),
  • a new validation folder (TSToSTS_patternRecognition) symmetric to the previous one,
  • a new validation folder (Morphology) containing the Tracksters histograms previously in the linking folder,
  • shrink of the score distributions due to a change in their definition.

A preliminary presentation can be found here.

PR validation:

runTheMatrix -l limited

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36712/27798

  • This PR adds an extra 604KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

  • DQMServices/Components (dqm)
  • DataFormats/HGCalReco (upgrade, reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)
  • SimCalorimetry/HGCalAssociatorProducers (upgrade, simulation)
  • Validation/HGCalValidation (dqm)
  • Validation/RecoTrack (dqm)

@civanch, @clacaputo, @emanueleusai, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @slava77, @jpata, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @barvic, @sethzenz, @apsallid, @felicepantaleo, @wmtford, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @cseez, @bsunanda, @sobhatta, @ebrondol, @pfs, @hatakeyamak, @mmusich, @lgray, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor

rovere commented Jan 14, 2022

assign hgcal-dpg

@cmsbuild
Copy link
Contributor

New categories assigned: hgcal-dpg

@felicepantaleo,@rovere,@pfs,@cseez you have been requested to review this Pull request/Issue and eventually sign? Thanks

@rovere
Copy link
Contributor

rovere commented Jan 14, 2022

Ciao @lecriste
thanks for this PR. As a very very preliminary comment, I would make the title more expressive and compress the history to some ten-ish commits.

@rovere
Copy link
Contributor

rovere commented Jan 14, 2022

@cmsbuild please test

@lecriste lecriste changed the title Pattern rec val lc Pattern Recognition validation for HGCal Tracksters Jan 14, 2022
@jpata
Copy link
Contributor

jpata commented Feb 10, 2022

+reconstruction

@civanch
Copy link
Contributor

civanch commented Feb 10, 2022

+1

@srimanob
Copy link
Contributor

+Upgrade

@rovere
Copy link
Contributor

rovere commented Feb 14, 2022

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 15, 2022

+1

@dan131riley
Copy link

Issue #36991 has been opened for a heap buffer overflow found in the ASAN IBs, likely related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants