Add muon shower comparison plots #36928

dinyar · 2022-02-10T18:15:50Z

PR description:

This PR adds comparison plots for hadronic showers between

the EMTF outputs and the uGMT inputs (currently deactivated until EMTF has an unpacker for its output showers)
the uGMT emulated and unpacked outputs
the six copies of uGMT outputs

PR validation:

Ran the emulator workflow on a private raw file containing showers without issues. This doesn't test the full functionality as we don't have muon shower copies outside of a global run and currently there are no unpacked showers from EMTF, however no crashes etc. were observed so I think this could go in for further validation at P5 and once we have EMTF unpackers.

attn: @vukasinmilosevic

cmsbuild · 2022-02-10T18:24:20Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36928/28255

This PR adds an extra 24KB to repository

cmsbuild · 2022-02-10T18:24:41Z

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2022-02-10T18:36:35Z

@dinyar are these changes affecting Online DQM? That's my understanding from your PR description
Thanks

dinyar · 2022-02-10T20:16:08Z

Hi @jfernan2,

Yes, that's the case. I've added a commit now, by the way that gates those plots behind the Run3 era.

Cheers,
Dinyar

jfernan2 · 2022-02-10T20:29:40Z

test parameters:

addpkg = DQM/Integration

cmsbuild · 2022-02-10T22:26:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36928/28261

This PR adds an extra 24KB to repository

cmsbuild · 2022-02-10T22:26:57Z

Pull request #36928 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2022-02-11T10:49:02Z

please test

cmsbuild · 2022-02-11T12:24:05Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19902b/22350/summary.html
COMMIT: e43f938
CMSSW: CMSSW_12_3_X_2022-02-10-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36928/22350/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-l1tstage2emulator_dqm_sourceclient had ERRORS

RelVals

312.0

----- Begin Fatal Exception 11-Feb-2022 12:32:32 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module L1TStage2MuonShowerComp/'l1tdeStage2uGMTShowers'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<l1t::MuonShower>
Looking for module label: valGmtStage2Digis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

11634.914

----- Begin Fatal Exception 11-Feb-2022 12:45:23 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module L1TStage2MuonShowerComp/'l1tdeStage2uGMTShowers'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<l1t::MuonShower>
Looking for module label: valGmtStage2Digis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

11634.0

----- Begin Fatal Exception 11-Feb-2022 12:45:26 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Calling method for module L1TStage2MuonShowerComp/'l1tdeStage2uGMTShowers'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: BXVector<l1t::MuonShower>
Looking for module label: valGmtStage2Digis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

136.897136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3/step2_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3.log
136.899136.899_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3/step2_RunCosmics2021CRAFT+RunCosmics2021CRAFT+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3.log
138.1138.1_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_PromptCosmics+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log

Expand to see more relval errors ...

This adds uGMT data-emulator comparisons and comparisons of the uGMT output copies.

cmsbuild · 2022-02-12T20:32:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36928/28296

This PR adds an extra 16KB to repository

cmsbuild · 2022-02-12T20:33:19Z

Pull request #36928 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

jfernan2 · 2022-02-12T20:56:50Z

please test

cmsbuild · 2022-02-13T01:03:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19902b/22380/summary.html
COMMIT: 6cdffa3
CMSSW: CMSSW_12_3_X_2022-02-12-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36928/22380/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764435
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3764399
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 10.405 KiB( 45 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 1.487 KiB L1TEMU/L1TdeStage2uGMT
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-02-13T15:42:05Z

+1

cmsbuild · 2022-02-13T15:42:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

pmandrik · 2022-02-14T12:29:37Z

Hello, @dinyar , please create the backport of the PR to CMSSW_12_2_1 also.

dinyar · 2022-02-14T14:03:47Z

Hi @pmandrik,

In principle this PR isn't needed for the next MWGR and I'll be on holidays for its duration, so unless you object I'd prefer to do a potential backport only upon my return. Let me know what you prefer.

Cheers,
Dinyar

pmandrik · 2022-02-14T14:42:31Z

Thanks for the answer, then we do not have any reasons to rush, have a good holiday!

qliphy · 2022-02-15T01:25:16Z

+1

Add comparisons between EMTF output and uGMT input for muon showers

763c87d

cmsbuild added this to the CMSSW_12_3_X milestone Feb 10, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Feb 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 10, 2022

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 10, 2022

dinyar force-pushed the feature/muon_shower_comparison_plots branch from 358162e to e43f938 Compare February 10, 2022 20:17

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 10, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 11, 2022

cmsbuild added tests-rejected and removed tests-started labels Feb 11, 2022

dinyar added 2 commits February 12, 2022 21:20

Add muon shower comparison plots

9325e60

This adds uGMT data-emulator comparisons and comparisons of the uGMT output copies.

Gate muon shower comparison plots behind Run3 era

6cdffa3

dinyar force-pushed the feature/muon_shower_comparison_plots branch from e43f938 to 6cdffa3 Compare February 12, 2022 20:24

cmsbuild added the tests-pending label Feb 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 12, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 12, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 13, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 13, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 15, 2022

cmsbuild merged commit 13b14e2 into cms-sw:master Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add muon shower comparison plots #36928

Add muon shower comparison plots #36928

dinyar commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

jfernan2 commented Feb 10, 2022

dinyar commented Feb 10, 2022

jfernan2 commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

jfernan2 commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

cmsbuild commented Feb 12, 2022

cmsbuild commented Feb 12, 2022

jfernan2 commented Feb 12, 2022

cmsbuild commented Feb 13, 2022

jfernan2 commented Feb 13, 2022

cmsbuild commented Feb 13, 2022

pmandrik commented Feb 14, 2022

dinyar commented Feb 14, 2022 •

edited

Loading

pmandrik commented Feb 14, 2022

qliphy commented Feb 15, 2022

Add muon shower comparison plots #36928

Add muon shower comparison plots #36928

Conversation

dinyar commented Feb 10, 2022

PR description:

PR validation:

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

jfernan2 commented Feb 10, 2022

dinyar commented Feb 10, 2022

jfernan2 commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

jfernan2 commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

Unit Tests

RelVals

RelVals-INPUT

cmsbuild commented Feb 12, 2022

cmsbuild commented Feb 12, 2022

jfernan2 commented Feb 12, 2022

cmsbuild commented Feb 13, 2022

Comparison Summary

jfernan2 commented Feb 13, 2022

cmsbuild commented Feb 13, 2022

pmandrik commented Feb 14, 2022

dinyar commented Feb 14, 2022 • edited Loading

pmandrik commented Feb 14, 2022

qliphy commented Feb 15, 2022

dinyar commented Feb 14, 2022 •

edited

Loading