Run3-alca247Z Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration #45044

bsunanda · 2024-05-25T10:15:16Z

PR description:

Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration

PR validation:

Used the scripts for getting calibration HCAL IsoTrack constants

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…CAL IsoTrack calibration

cmsbuild · 2024-05-25T10:15:40Z

cms-bot internal usage

cmsbuild · 2024-05-25T10:25:27Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45044/40347

This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45044/40347/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45044/40347/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-05-25T10:38:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45044/40348

This PR adds an extra 68KB to repository

cmsbuild · 2024-05-25T10:38:33Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos (alca)

@cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@mmusich, @yuanchao, @rsreds, @tocheng this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2024-05-25T10:39:02Z

@cmsbuild Please test

perrotta · 2024-05-25T12:54:30Z

Calibration/HcalCalibAlgos/macros/CalibCorr.C

@@ -144,6 +148,12 @@ unsigned int truncateId(unsigned int detId, int truncateFlag, bool debug = false
    //Ignore depth index for depth > 1 in HB and HE
    if (depth > 1)
      depth = 2;
+  } else if (truncate0 == 6) {
+    //Ignore depth index for depth > 1 in HB and HE


The comment is the same as the one at L148, but the range of depth's is different: please fix the comment

perrotta · 2024-05-25T12:57:46Z

Calibration/HcalCalibAlgos/macros/CalibPlotProperties.C

-//                               (Default 0)
+//                               in HB and HE with values > 1 as depth 2 (5),
+//                               for depth = 1 and 2, depth = 1, else depth
+//                                = 2. (Default 0)


Suggested change

// = 2. (Default 0)

// = 2 (6). (Default 0)

cmsbuild · 2024-05-25T13:42:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-459001/39524/summary.html
COMMIT: b5b047b
CMSSW: CMSSW_14_1_X_2024-05-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45044/39524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 854
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3337988
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-05-26T04:25:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45044/40351

This PR adds an extra 68KB to repository

cmsbuild · 2024-05-26T04:26:13Z

Pull request #45044 was updated. @consuegs, @saumyaphor4252, @perrotta can you please check and sign again.

perrotta · 2024-05-26T06:17:51Z

please test

cmsbuild · 2024-05-26T13:30:52Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-459001/39528/summary.html
COMMIT: f1b31a2
CMSSW: CMSSW_14_1_X_2024-05-26-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45044/39528/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

136.766136.766_RunSinglePh2016E/step2_RunSinglePh2016E.log
136.765136.765_RunSingleMu2016E/step2_RunSingleMu2016E.log
136.7611136.7611_RunJetHT2016EreMINIAOD/step2_RunJetHT2016EreMINIAOD.log

Expand to see more relval errors ...

136.76111
136.768
136.769

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338839
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta · 2024-05-26T13:48:59Z

please test
(errors are clearly unrelated, but let see if they reset if we relaunch the tests)

cmsbuild · 2024-05-26T16:38:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-459001/39532/summary.html
COMMIT: f1b31a2
CMSSW: CMSSW_14_1_X_2024-05-26-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45044/39532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 7 lines to the logs
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3338862
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338842
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

perrotta · 2024-05-26T17:21:29Z

+alca

cmsbuild · 2024-05-26T17:21:53Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-05-28T14:43:17Z

+1

Add a new defintion of truncated DetID and a new scaling script for H…

987080a

…CAL IsoTrack calibration

cmsbuild added this to the CMSSW_14_1_X milestone May 25, 2024

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 25, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 25, 2024

Code check

b5b047b

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 25, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 25, 2024

cmsbuild added tests-started and removed tests-pending labels May 25, 2024

perrotta reviewed May 25, 2024

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels May 25, 2024

Take Andrea's comments

f1b31a2

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels May 26, 2024

cmsbuild added tests-started and removed tests-pending labels May 26, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels May 26, 2024

cmsbuild added tests-rejected and removed tests-started labels May 26, 2024

cmsbuild added tests-started and removed tests-rejected labels May 26, 2024

cmsbuild added tests-approved and removed tests-started labels May 26, 2024

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels May 26, 2024

cmsbuild added orp-approved and removed orp-pending labels May 28, 2024

cmsbuild merged commit 1b89ee1 into cms-sw:master May 28, 2024
11 checks passed

This was referenced May 28, 2024

Rivet 4.0.0 and YODA 2.0.0 cms-sw/cmsdist#9111

Merged

[ROOT632] Root update v6 32 00 patches cms-sw/cmsdist#9211

Merged

[CPP20] remove depracated use of volatile as for #45072 #45091

Merged

[CPP20] Remove volatile from CondCore/Utilities #45104

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca247Z Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration #45044

Run3-alca247Z Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration #45044

bsunanda commented May 25, 2024

cmsbuild commented May 25, 2024 •

edited

Loading

cmsbuild commented May 25, 2024

cmsbuild commented May 25, 2024

cmsbuild commented May 25, 2024

bsunanda commented May 25, 2024

perrotta May 25, 2024

perrotta May 25, 2024

cmsbuild commented May 25, 2024

cmsbuild commented May 26, 2024

cmsbuild commented May 26, 2024

perrotta commented May 26, 2024

cmsbuild commented May 26, 2024

perrotta commented May 26, 2024

cmsbuild commented May 26, 2024

perrotta commented May 26, 2024

cmsbuild commented May 26, 2024

antoniovilela commented May 28, 2024

Run3-alca247Z Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration #45044

Run3-alca247Z Add a new defintion of truncated DetID and a new scaling script for HCAL IsoTrack calibration #45044

Conversation

bsunanda commented May 25, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented May 25, 2024 • edited Loading

cmsbuild commented May 25, 2024

cmsbuild commented May 25, 2024

cmsbuild commented May 25, 2024

bsunanda commented May 25, 2024

perrotta May 25, 2024

Choose a reason for hiding this comment

perrotta May 25, 2024

Choose a reason for hiding this comment

cmsbuild commented May 25, 2024

Comparison Summary

cmsbuild commented May 26, 2024

cmsbuild commented May 26, 2024

perrotta commented May 26, 2024

cmsbuild commented May 26, 2024

RelVals-INPUT

Comparison Summary

perrotta commented May 26, 2024

cmsbuild commented May 26, 2024

Comparison Summary

perrotta commented May 26, 2024

cmsbuild commented May 26, 2024

antoniovilela commented May 28, 2024

cmsbuild commented May 25, 2024 •

edited

Loading