Skip to content

Conversation

krivard
Copy link
Contributor

@krivard krivard commented Oct 17, 2022

image

Changelog

Remove column gap (from custom scss) and offset (from theme layout file).

NB setting offset to 0 instead of 0px gives us back #616 behavior, not sure why

Fixes #692. NB setting offset to 0 instead of 0px gives us back #616 behavior, not sure why
@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit 47429ea
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/634dca7f2b37680009e88105
😎 Deploy Preview https://deploy-preview-715--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@krivard krivard requested a review from carlynvandyke October 17, 2022 21:37
@krivard
Copy link
Contributor Author

krivard commented Oct 17, 2022

@carlynvandyke just looking for an extra visual confirmation that I didn't screw anything up in the process of fixing this navbar spacing issue

Copy link
Contributor

@carlynvandyke carlynvandyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@krivard krivard merged commit a84078f into dev Oct 18, 2022
@krivard krivard deleted the krivard/fix-spacing branch October 18, 2022 13:36
@krivard krivard mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav menus display too high
2 participants