Add netlify-OAuth #263
Open
Add netlify-OAuth #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The OAuth can be tested at: https://5d27924ef3c5950008706b3a--determined-goldstine-6dc504.netlify.com/ |
KVGarg
force-pushed
the
netlify-oauth
branch
2 times, most recently
from
d512c68
to
fdfd5b1
Compare
Travis tests have failedHey @KVGarg, 1st Buildcoala --non-interactive -VTravisBuddy Request Identifier: b7a35d60-a470-11e9-bd96-c5bef65e495d |
KVGarg
force-pushed
the
netlify-oauth
branch
2 times, most recently
from
31f402c
to
a5519b4
Compare
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: 8b6a1e00-ab7d-11e9-bd4a-b1db5eb8f7db |
Travis tests have failedHey @KVGarg, 1st BuildpytestTravisBuddy Request Identifier: 4a788310-ab86-11e9-b158-b5ca4a0ddf5e |
The updation in model adds new data fields which will be useful, in further work. Also, it will reduce the API calls, which are being made to fetch these information. Instead of making new API Calls, we can get them from webservices and use them directly.
The openhub module got disabled due to some reasons in community project last year. And, currently the module is raising the CI errors which need to be avoided. They can be worked on once we're ready to enable the openhub module once again in this project in future.
As in future, the data will be fetched from coala-webservices intead of @sks444 repository (webservices.coala.io). So, to remove that dependency the tests have been modified accordingly.
Running command ".ci/build.sh" locally on pc used to failed the build, if there is more than one git remote's. Fixes coala#235
The enhancement includes addition of materialize css, JQuery, responsiveness, and easy-navigation of website features. The easy-navigatibility is achieved by adding a navbar with display of meta -review and gamification leaderboard on homepage. Apart from this, the activity graph url is omitted from website by displaying the graph itslef on the homepage on large devices. Closes coala#255
The newly created webpage combines the previous two webpages- info.txt and log/index.html. This web-page combines the results of both the pages and shows them in a better UI/UX with additional features of filtering and searching within the existing logs. The logs are fetched from a JSON file which is created from the logs stored in the log file _site/community.log Closes coala#256
The redesigned web-page displays the data in a better UI/UX form with some additional information to make it more interactive and attractive. Closes coala#257
The redesigned web-page provides a nice UI/UX design to the web-page with "search" feature. Closes coala#259
The redesigned webpages provides a enhanced UI/UX design to web-page with additional functionality of searching the contributors. Closes coala#260
The contributor can sign-in with either GitHub or GitLab account provided the user is member of the organization. The validation is being performed via a http request which accepts the access_token retrieved from the netlify o-authentication. Closes coala#262
|
@KVGarg, can you show the preview of working OAuth flow on your fork? |
|
@sks444 The deployed version doesn't have OAuth token validation which is being checked in webservices. Omitted that check in testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contributor can sign-in with either
GitHub or GitLab account provided the
user is member of the organization. The
validation is being performed via a http
request which accepts the access_token
retrieved from the netlify o-authentication.
Closes #262