Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/backupccl: TestBackupRestoreSystemUsers failed #123870

Closed
cockroach-teamcity opened this issue May 9, 2024 · 0 comments · Fixed by #124047
Closed

ccl/backupccl: TestBackupRestoreSystemUsers failed #123870

cockroach-teamcity opened this issue May 9, 2024 · 0 comments · Fixed by #124047
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 9, 2024

ccl/backupccl.TestBackupRestoreSystemUsers failed on master @ c6b012b6d77c8fda71bd9c4dd24570895f32cbbe:

=== RUN   TestBackupRestoreSystemUsers
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestBackupRestoreSystemUsers42823656
    test_log_scope.go:81: use -show-logs to present logs inline
    test_server_shim.go:157: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    test_server_shim.go:157: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    test_server_shim.go:157: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    test_server_shim.go:157: automatically injected a shared process virtual cluster under test; see comment at top of test_server_shim.go for details.
    testutils.go:290: no Invalid Descriptors
    testutils.go:290: no Invalid Descriptors
    testutils.go:290: no Invalid Descriptors
    testutils.go:290: no Invalid Descriptors
    backup_test.go:10046: -- test log scope end --
test logs left over in: outputs.zip/logTestBackupRestoreSystemUsers42823656
--- FAIL: TestBackupRestoreSystemUsers (187.58s)
=== RUN   TestBackupRestoreSystemUsers/restore-from-backup-with-existing-user
    backup_test.go:10027: query 'SELECT * FROM system.users': expected:
        admin, , true, 2
        app, NULL, false, 101
        app_role, NULL, true, 102
        root, , false, 1
        test, NULL, false, 103
        test_role, NULL, true, 104
        testuser, NULL, false, 100
        
        got:
        admin, , true, 2
        app, NULL, false, 102
        app_role, NULL, true, 103
        root, , false, 1
        test, NULL, false, 104
        test_role, NULL, true, 105
        testuser, NULL, false, 101
        
    --- FAIL: TestBackupRestoreSystemUsers/restore-from-backup-with-existing-user (40.29s)

Parameters:

  • attempt=1
  • race=true
  • run=1
  • shard=23
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-38581

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery labels May 9, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone May 9, 2024
@exalate-issue-sync exalate-issue-sync bot added the P-1 Issues/test failures with a fix SLA of 1 month label May 13, 2024
craig bot pushed a commit that referenced this issue May 13, 2024
123990: schemachanger: consider "dropping" columns during alter primary key r=annrpom a=MattSilvaa

Previously, using the "comma syntax" for dropping a col and altering the primary key with the same name
(`alter table t drop column i, alter primary key using columns(i);`) led to an internal error. This commit makes it so that the error will instead be a proper external error by ensuring that resolving columns in the DSC considers the "dropping" state.

Fixes: #122917

Epic: CRDB-37763

Release note: None

124047: streamingccl: deflake TestBackupRestoreSystemUsers r=kev-cao a=msbutler

Fixes #123870

Release note: none

Co-authored-by: Matheus Muniz da Silva <20505926+MattSilvaa@users.noreply.github.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
@craig craig bot closed this as completed in a621810 May 13, 2024
blathers-crl bot pushed a commit that referenced this issue May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants