Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: add StoreLiveness interface #125258

Closed
arulajmani opened this issue Jun 6, 2024 · 2 comments · Fixed by #126034
Closed

raft: add StoreLiveness interface #125258

arulajmani opened this issue Jun 6, 2024 · 2 comments · Fixed by #126034
Assignees
@arulajmani
Labels
A-kv-replication Relating to Raft, consensus, and coordination. A-leader-leases Related to the introduction of leader leases C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team

Comments

@arulajmani
Copy link
Collaborator

arulajmani commented Jun 6, 2024 •
edited by exalate-issue-sync bot
Loading

Part of #123847

Every raft group needs access to the store liveness fabric to answer questions about support from/for peers in its raft group.

Jira issue: CRDB-39349

Epic CRDB-37522
@arulajmani arulajmani added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jun 6, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Jun 6, 2024

Hi @arulajmani, please add branch-* labels to identify which branch(es) this C-bug affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@arulajmani arulajmani added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Jun 6, 2024
@arulajmani arulajmani added A-kv-replication Relating to Raft, consensus, and coordination. A-leader-leases Related to the introduction of leader leases labels Jun 6, 2024
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Jun 6, 2024

cc @cockroachdb/replication

@arulajmani arulajmani self-assigned this Jun 6, 2024
@arulajmani arulajmani mentioned this issue Jun 21, 2024
Merged
arulajmani added a commit to arulajmani/cockroach that referenced this issue Jun 24, 2024
@arulajmani
raft: add the StoreLiveness interface
89f815f 
There's not much here, other than porting the interface definition
from the prototype and plumbing it from the Config to the raft struct.

Closes cockroachdb#125258

Release note: None
craig bot pushed a commit that referenced this issue Jul 1, 2024
@arulajmani
Merge #126034
84c50dc 
126034: raft: add the StoreLiveness interface r=arulajmani a=arulajmani

There's not much here, other than porting the interface definition from the prototype and plumbing it from the Config to the raft struct.

Closes #125258

Co-authored-by: Arul Ajmani <arulajmani@gmail.com>
@craig craig bot closed this as completed in 4650de2 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
A-kv-replication Relating to Raft, consensus, and coordination. A-leader-leases Related to the introduction of leader leases C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-kv KV Team
Projects
No open projects
KV
Status: Incoming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raft: add the StoreLiveness interface arulajmani/cockroach
1 participant
@arulajmani