Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/jobs/jobsprofiler/jobsprofiler_test: TestTraceRecordingOnResumerCompletion failed #126093

Closed
cockroach-teamcity opened this issue Jun 24, 2024 · 0 comments · Fixed by #126108
Closed

pkg/jobs/jobsprofiler/jobsprofiler_test: TestTraceRecordingOnResumerCompletion failed #126093

cockroach-teamcity opened this issue Jun 24, 2024 · 0 comments · Fixed by #126108
Assignees
@dt
Labels
A-disaster-recovery A-jobs branch-release-24.1.2-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-3 Issues/test failures with no fix SLA release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-jobs
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 24, 2024 •
edited by cockroach-jira-scripts
Loading

pkg/jobs/jobsprofiler/jobsprofiler_test.TestTraceRecordingOnResumerCompletion failed on release-24.1.2-rc @ 4037be1494ff8f3873edfa2510a7fa79545b413e:

=== RUN   TestTraceRecordingOnResumerCompletion
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestTraceRecordingOnResumerCompletion3998100160
    test_log_scope.go:81: use -show-logs to present logs inline
    test_server_shim.go:157: automatically injected an external process virtual cluster under test; see comment at top of test_server_shim.go for details.
    profiler_test.go:215: condition failed to evaluate within 2m0s: from jobs_verification.go:101: expected job status succeeded, but got running
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestTraceRecordingOnResumerCompletion3998100160
--- FAIL: TestTraceRecordingOnResumerCompletion (225.77s)

Parameters:

  • attempt=1
  • race=true
  • run=3
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/jobs @cockroachdb/disaster-recovery

This test on roachdash | Improve this report!

Jira issue: CRDB-39771
@cockroach-teamcity cockroach-teamcity added branch-release-24.1.2-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-disaster-recovery T-jobs labels Jun 24, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Jun 24, 2024
@exalate-issue-sync exalate-issue-sync bot added P-3 Issues/test failures with no fix SLA and removed T-disaster-recovery labels Jun 24, 2024
@rickystewart rickystewart mentioned this issue Jun 24, 2024
Merged
craig bot pushed a commit that referenced this issue Jun 24, 2024
@yuzefovich @rickystewart
Merge #126051 #126107 #126108
91d779f 
126051: sql: fix stmt stats for internal executors with outer txns r=yuzefovich a=yuzefovich

This commit fixes an oversight where we previously incorrectly used `fromOuterTxn` boolean when instantiating the stats container. This field was originally introduced to indicate that some schema objects shouldn't be reset when resetting the conn executor, which is the case when we have an outer txn AND we injected the descs collection, etc. For the stats container we only care about whether there is an outer txn or not. This commit splits out the boolean into two to clarify things. Now, whenever we're `underOuterTxn` we'll do the right thing for the stats container, and the old boolean `fromOuterTxn` has been renamed to `skipResettingSchemaObjects` to avoid possible confusion.

I think the same problem was present with the usage of `fromOuterTxn` when ensuring that we step back the txn in the internal executor, and this is now fixed.

Additionally, it adds a few TODOs about code spots we might need to change to address an issue with txn stats of internal executors.

Epic: None

Release note: None

126107: rpc: grant test an additional core under `race` r=rail a=rickystewart

Closes #126092.

Epic: none
Release note: None

126108: jobsprofiler: bump size of test under `race` r=rail a=rickystewart

Closes #126093.

Epic: none
Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in cffb548 Jun 24, 2024
blathers-crl bot pushed a commit that referenced this issue Jun 24, 2024
@rickystewart
jobsprofiler: bump size of test under race
5e66945 
Closes #126093.

Epic: none
Release note: None
@blathers-crl blathers-crl bot mentioned this issue Jun 24, 2024
Merged
asg0451 pushed a commit to asg0451/cockroach that referenced this issue Jun 25, 2024
@rickystewart @asg0451
jobsprofiler: bump size of test under race
60881bb 
Closes cockroachdb#126093.

Epic: none
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dt dt

Labels
A-disaster-recovery A-jobs branch-release-24.1.2-rc C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-3 Issues/test failures with no fix SLA release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-jobs
Projects
No open projects
Disaster Recovery Backlog
Status: Done
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

jobsprofiler: bump size of test under race rickystewart/cockroach
2 participants
@dt @cockroach-teamcity