sql: add telemetry block regexps and fix flake #117558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `feature-allowlist` directive for telemetry tests has been renamed `feature-list` and it now supports blocking regexps. Any line in the `feature-list` that starts with "!" is a block regexp that prevents any features matching the regexp from being included in the output of the `feature-usage` and `feature-counters` directives. This is helpful because Go's regexps do not support negative look-aheads, so adding features that should not be matched is difficult and tedious. Release note: None
This commit ignores the `sql.schema.create_stats` in the `schema` telemetry tests because it causes sporadic failures. Fixes cockroachdb#117309 Release note: None
mgartner
requested review from
a team and
michae2
and removed request for
a team
|
This change is |
michae2
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Reviewed 27 of 27 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
|
TFTR! bors r+ |
|
Build succeeded: |
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqltestutils: allow blocking regexps in telemetry feature list
The
feature-allowlistdirective for telemetry tests has been renamedfeature-listand it now supports blocking regexps. Any line in thefeature-listthat starts with "!" is a block regexp that prevents anyfeatures matching the regexp from being included in the output of the
feature-usageandfeature-countersdirectives. This is helpfulbecause Go's regexps do not support negative look-aheads, so adding
features that should not be matched is difficult and tedious.
Release note: None
sql: ignore "sql.schema.create_stats" in schema telemetry test
This commit ignores the
sql.schema.create_statsin theschematelemetry tests because it causes sporadic failures.
Fixes #117309
Release note: None