Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestTelemetry failed #117309

Closed
cockroach-teamcity opened this issue Jan 4, 2024 · 2 comments · Fixed by #117558
Closed

sql: TestTelemetry failed #117309

cockroach-teamcity opened this issue Jan 4, 2024 · 2 comments · Fixed by #117558
Assignees
@mgartner
Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jan 4, 2024 •
edited by cockroach-jira-scripts
Loading

sql.TestTelemetry failed with artifacts on release-23.1 @ 443b99b1cbe2a42e8cbf4e59678cf7254f2bdccd:

        DROP INDEX t_b_idx;
        SELECT 1/0;
        ----
        error: pq: division by zero
    datadriven.go:144: 
        testdata/telemetry/schema:187:
        feature-usage [0 args]
        ROLLBACK;
        ----
        sql.schema.transaction.mixed_ddl_dml.failure
    datadriven.go:144: 
        testdata/telemetry/schema:192:
        exec [0 args]
        BEGIN;
        DROP INDEX t_b_idx;
        ----
    datadriven.go:144: 
        testdata/telemetry/schema:197:
        feature-usage [0 args]
        ROLLBACK;
        ----
        sql.schema.transaction.ddl_only.failure
    datadriven.go:144: 
        testdata/telemetry/schema:202:
        feature-usage [0 args]
        BEGIN;
        SELECT 1;
        DROP INDEX t_b_idx;
        COMMIT;
        ----
        sql.schema.change_in_explicit_txn
        sql.schema.drop_index
        sql.schema.get_virtual_table.pg_catalog.pg_attribute
        sql.schema.schema_changer_mode.legacy
        sql.schema.transaction.mixed_ddl_dml.success
    datadriven.go:144: 
        testdata/telemetry/schema:214:
         BEGIN;
        CREATE INDEX ON t(b);
        COMMIT;
        output didn't match expected:
        @@ -1,6 +1,7 @@
         sql.schema.change_in_explicit_txn
         sql.schema.create_index
        +sql.schema.create_stats
         sql.schema.get_virtual_table.pg_catalog.pg_attribute
         sql.schema.schema_changer_mode.legacy
         sql.schema.transaction.ddl_only.success
         
        --- FAIL: TestTelemetry/schema/tenant (25.04s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-35114
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Jan 4, 2024
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Jan 4, 2024
@mgartner

This comment was marked as outdated.

Sign in to view
@cockroach-teamcity
Copy link
Member Author

sql.TestTelemetry failed with artifacts on release-23.1 @ 1391d7d808cb769709890075cd5e05e7f7a5d9c2:

        DROP INDEX t_b_idx;
        SELECT 1/0;
        ----
        error: pq: division by zero
    datadriven.go:144: 
        testdata/telemetry/schema:187:
        feature-usage [0 args]
        ROLLBACK;
        ----
        sql.schema.transaction.mixed_ddl_dml.failure
    datadriven.go:144: 
        testdata/telemetry/schema:192:
        exec [0 args]
        BEGIN;
        DROP INDEX t_b_idx;
        ----
    datadriven.go:144: 
        testdata/telemetry/schema:197:
        feature-usage [0 args]
        ROLLBACK;
        ----
        sql.schema.transaction.ddl_only.failure
    datadriven.go:144: 
        testdata/telemetry/schema:202:
        feature-usage [0 args]
        BEGIN;
        SELECT 1;
        DROP INDEX t_b_idx;
        COMMIT;
        ----
        sql.schema.change_in_explicit_txn
        sql.schema.drop_index
        sql.schema.get_virtual_table.pg_catalog.pg_attribute
        sql.schema.schema_changer_mode.legacy
        sql.schema.transaction.mixed_ddl_dml.success
    datadriven.go:144: 
        testdata/telemetry/schema:214:
         BEGIN;
        CREATE INDEX ON t(b);
        COMMIT;
        output didn't match expected:
        @@ -1,6 +1,7 @@
         sql.schema.change_in_explicit_txn
         sql.schema.create_index
        +sql.schema.create_stats
         sql.schema.get_virtual_table.pg_catalog.pg_attribute
         sql.schema.schema_changer_mode.legacy
         sql.schema.transaction.ddl_only.success
         
        --- FAIL: TestTelemetry/schema/tenant (25.87s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@mgartner mgartner mentioned this issue Jan 9, 2024
Merged
@mgartner mgartner self-assigned this Jan 9, 2024
@mgartner mgartner removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Jan 9, 2024
craig bot pushed a commit that referenced this issue Jan 11, 2024
@andrewbaptist @mgartner
@homa31 @Xiang-Gu
Merge #113893 #117542 #117558 #117569 #117572
f428c19 
113893: cli: remove cockroach connect r=nvanbenschoten a=andrewbaptist

`connect` was implemented as an experiment to allow bootstrapping nodes from other nodes CA's (#60632). The details are described here: https://github.com/aaron-crl/toy-secure-init-handshake/tree/n-way-join

This implementation was never completed, and the visibility of this code can cause confusion. This PR removes all the code with the idea that we can bring it back later if necessary.

Epic: none

Release note (cli change): Removal of the `cockroach connect` functionality.

117542: sql: fix erroneous benchmark regressions r=mgartner a=mgartner

Several benchmarks incorrectly included cluster shutdown as part of the
benchmark timing. This caused major regressions in benchmarks
when #117116 was merged because it made cluster shutdown slower. The
benchmarks now stop the timer before initiating cluster shutdown to more
accurately measure the code in question.

Fixes #117494

Release note: None


117558: sql: add telemetry block regexps and fix flake r=mgartner a=mgartner

#### sqltestutils: allow blocking regexps in telemetry feature list

The `feature-allowlist` directive for telemetry tests has been renamed
`feature-list` and it now supports blocking regexps. Any line in the
`feature-list` that starts with "!" is a block regexp that prevents any
features matching the regexp from being included in the output of the
`feature-usage` and `feature-counters` directives. This is helpful
because Go's regexps do not support negative look-aheads, so adding
features that should not be matched is difficult and tedious.

Release note: None

#### sql: ignore "sql.schema.create_stats" in schema telemetry test

This commit ignores the `sql.schema.create_stats` in the `schema`
telemetry tests because it causes sporadic failures.

Fixes #117309

Release note: None


117569: authors: add homa31 to authors r=homa31 a=homa31

Release note: None
Epic: None

117572: *: Prep work for supporting CONFIGURE ZONE in declarative schema changer r=Xiang-Gu a=Xiang-Gu

This PR consists several preparation work that will be needed for properly supporting CONFIGURE ZONE stmts in declarative schema changer. They're separated out for easier review and bc I expect those to be a lot less controversial than the main work. See each commit for details.

Informs #117574
Epic: CRDB-31473

Co-authored-by: Andrew Baptist <baptist@cockroachlabs.com>
Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
Co-authored-by: Howard Ma <howard.ma@cockroachlabs.com>
Co-authored-by: Xiang Gu <xiang@cockroachlabs.com>
@craig craig bot closed this as completed in 819888b Jan 11, 2024
@mgartner mgartner mentioned this issue Feb 12, 2024
Merged
mgartner added a commit to mgartner/cockroach that referenced this issue Feb 12, 2024
@mgartner
sql: ignore "sql.schema.create_stats" in schema telemetry test
6875b84 
This commit ignores the `sql.schema.create_stats` in the `schema`
telemetry tests because it causes sporadic failures.

Fixes cockroachdb#117309

Release note: None
@mgartner mgartner mentioned this issue Feb 12, 2024
Merged
mgartner added a commit to mgartner/cockroach that referenced this issue Feb 27, 2024
@mgartner
sql: ignore "sql.schema.create_stats" in schema telemetry test
24a970e 
This commit ignores the `sql.schema.create_stats` in the `schema`
telemetry tests because it causes sporadic failures.

Fixes cockroachdb#117309

Release note: None
mgartner added a commit to mgartner/cockroach that referenced this issue Feb 27, 2024
@mgartner
sql: ignore "sql.schema.create_stats" in schema telemetry test
781c4f7 
This commit ignores the `sql.schema.create_stats` in the `schema`
telemetry tests because it causes sporadic failures.

Fixes cockroachdb#117309

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgartner mgartner

Labels
branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
SQL Queries
Archived in project
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

sql: add telemetry block regexps and fix flake mgartner/cockroach
2 participants
@mgartner @cockroach-teamcity