Skip to content

release-24.1: sql/schemachanger: fix incorrect clean up of sequence ownership #152312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025
Merged

release-24.1: sql/schemachanger: fix incorrect clean up of sequence ownership #152312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions pkg/sql/logictest/testdata/logic_test/sequences
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2539,3 +2539,39 @@ SELECT substring(sequence_schema FOR 7), sequence_name FROM [SHOW SEQUENCES] WHE
pg_temp temp_seq

subtest end


subtest incorrect_cleanup_of_owned_by

statement ok
CREATE TABLE t_seq_owner (id BIGSERIAL NOT NULL);

statement ok
CREATE SEQUENCE id_seq_owned OWNED BY t_seq_owner.id;

statement ok
ALTER TABLE t_seq_owner ALTER COLUMN id SET DEFAULT nextval('id_seq_owned');

# Confirm the sequence still exists.
query I
SELECT count(*) FROM pg_sequences WHERE sequencename='id_seq_owned';
----
1


statement ok
drop table t_seq_owner;

# Confirm the sequence is dropped.
query I
SELECT count(*) FROM pg_sequences WHERE sequencename='id_seq_owned';
----
0

# Confirm the table is dropped.
query I
SELECT count(*) FROM pg_tables WHERE tablename='t_seq_owner';
----
0

subtest end
1 change: 0 additions & 1 deletion pkg/sql/schemachanger/scexec/scmutationexec/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,6 @@ func updateColumnExprSequenceUsage(d *descpb.ColumnDescriptor) error {
ids.ForEach(all.Add)
}
d.UsesSequenceIds = all.Ordered()
d.OwnsSequenceIds = all.Ordered()
return nil
}

Expand Down