Skip to content

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Sep 22, 2025

Informs #153276

Release note (ops change): In an upcoming release, we're deprecating removing the bespoke restore and import event logs. For any customer that relies on those logs, we can maintain UX parity by plumbing the sql user that created the job to the status change event log.

@msbutler msbutler self-assigned this Sep 22, 2025
Copy link

blathers-crl bot commented Sep 22, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler force-pushed the butler-add-user-state-change branch from 2edb119 to e57b9ec Compare September 22, 2025 17:56
@msbutler msbutler marked this pull request as ready for review September 22, 2025 19:31
@msbutler msbutler requested review from a team as code owners September 22, 2025 19:31
@msbutler msbutler requested review from angles-n-daemons, arjunmahishi, aa-joshi, Abhinav1299 and kev-cao and removed request for a team September 22, 2025 19:31
@msbutler
Copy link
Collaborator Author

unrelated flake

@dt
Copy link
Member

dt commented Sep 23, 2025

nit: user is the user that owns the job, which is nominally the creator but ownership can be transferred.

@msbutler msbutler force-pushed the butler-add-user-state-change branch 3 times, most recently from 217cff3 to 8b2daab Compare September 24, 2025 12:07
Informs cockroachdb#153276

Release note (ops change): In an upcoming release, we're deprecating the
bespoke restore and import event logs. For any customer that relies on those
logs, we can maintain UX parity by plumbing the sql user that owns the
job to the status change event log.
@msbutler msbutler force-pushed the butler-add-user-state-change branch from 8b2daab to fc50678 Compare September 24, 2025 14:22
@msbutler
Copy link
Collaborator Author

TFTR!

bors r=dt

@craig
Copy link
Contributor

craig bot commented Sep 24, 2025

@craig craig bot merged commit 926c159 into cockroachdb:master Sep 24, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants