pgwire: show RowDescription for EXECUTE when needed #153905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rafiss
force-pushed
the
pgwire-fix-execute
branch
from
fdbacae to
a753025
Compare
fqazi
approved these changes
Sep 23, 2025
There was a problem hiding this comment.
@fqazi reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
Release note (bug fix): Fixed a bug where we would not show the pgwire RowDescription for EXECUTE statements that were themselves prepared using the pgwire Parse command.
rafiss
force-pushed
the
pgwire-fix-execute
branch
from
a753025 to
ed98093
Compare
|
tftr! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
153464: server: only auto-upgrade system tenant from meta1 leaseholder r=arulajmani a=stevendanna Running the auto-upgrade process from all nodes does some amount of wasted work. Let's avoid that by only running it from the meta1 leaseholder. This only applies to the system tenant. For shared-process multi-tenancy, we may consider allowing secondary tenants access to this same information. For separate process multi-tenancy, a different solution would be needed. Informs #152916 Release note: None 153624: ui: bump cluster-ui to 25.4 prerelease r=dhartunian a=dhartunian Resolves: CC-33581 Epic: None Release note: None 153905: pgwire: show RowDescription for EXECUTE when needed r=rafiss a=rafiss fixes #153505 Release note (bug fix): Fixed a bug where we would not show the pgwire RowDescription for EXECUTE statements that were themselves prepared using the pgwire Parse command. 153954: changefeedccl: fix TestAlterChangefeedAddTargetsDuringSchemaChangeError r=KeithCh,asg0451 a=andyyang890 This patch deflakes a unit test that started failing because the change to checkpoint aggregators regularly meant that setting a low span-level checkpoint interval wasn't enough to make sure a checkpoint happened quickly enough during the test. Fixes #153918 Release note: None Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: David Hartunian <davidh@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: Andy Yang <yang@cockroachlabs.com>
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
153464: server: only auto-upgrade system tenant from meta1 leaseholder r=arulajmani a=stevendanna Running the auto-upgrade process from all nodes does some amount of wasted work. Let's avoid that by only running it from the meta1 leaseholder. This only applies to the system tenant. For shared-process multi-tenancy, we may consider allowing secondary tenants access to this same information. For separate process multi-tenancy, a different solution would be needed. Informs #152916 Release note: None 153905: pgwire: show RowDescription for EXECUTE when needed r=rafiss a=rafiss fixes #153505 Release note (bug fix): Fixed a bug where we would not show the pgwire RowDescription for EXECUTE statements that were themselves prepared using the pgwire Parse command. Co-authored-by: Steven Danna <danna@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
|
Build failed (retrying...): |
celeste-cockroachdb
bot
added
v25.4.0-prerelease
and removed
target-release-25.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #153505
Release note (bug fix): Fixed a bug where we would not show the pgwire RowDescription for EXECUTE statements that were themselves prepared using the pgwire Parse command.