release-25.4: roachtest/mixedversion: sync workload binary versions with the cluste… #154562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
|
This change is |
williamchoe3
requested review from
srosenberg and
DarrylWong
and removed request for
a team
williamchoe3
changed the title
srosenberg
approved these changes
Oct 2, 2025
…r version The current workload binary is no longer backwards compatible for certain workloads. Previously, the workload binary would just use whatever default binary was staged on the workload node. Currently, there's a quick fix that installs the current system version's binary on the workload node when a workload cmd is being executed. This change bakes that behavior into the test framework itself, so we can remove the binary staging from the Workload hook. Workload nodes are staged with all versioned binaries in the upgrade plan so all workload commands can use a versioned binary that matches the current state of the cluster. Note: This commit diverges slightly from the original due to merge conflicts. See PR for more details. Resolves cockroachdb#147374 Epic: None Release note: None
williamchoe3
force-pushed
the
backport25.4-153269
branch
from
1d523e9 to
dbe7107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #153269
Note: Due to a non backported change that affected how plans are generated, this commit differs slightly from the commit to master, most notably the datadriven tests' expected output files have diverged because the expected plans are different.
roachtest/mixedversion: sync workload binary versions with the cluster version
The current workload binary is no longer backwards compatible for certain
workloads. Previously, the workload binary would just use whatever default
binary was staged on the workload node. Currently, there's a quick fix that
installs the current system version's binary on the workload node when a
workload cmd is being executed.
This change bakes that behavior into the test framework itself, so we can remove
the binary staging from the Workload hook. Workload nodes are staged with all
versioned binaries in the upgrade plan so all workload commands can use a
versioned binary that matches the current state of the cluster.
Resolves #147374
Epic: None
Release note: None
Release justification: mixedversion test changes so tests that use non backwards compatible workloads i.e. bank don't fail on workload commands