azure: use ResumingReader #155287
Merged
azure: use ResumingReader #155287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the azure client did not use the ResumingReader. This was causing tracing span use after free issues as the client would issue http retries with a span that was already finished. The ResumingReader manages a span for the lifetime of the reader. There is also some evidence in cockroachdb#154483 that the RetryReader built into the azure client did not properly retry errors that occur while reading the body. Fixes: 154849 Release note: none
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
I feel so/so about this change. It brings the implementation of the azure client in line with how the gcs/aws clients are implemented. But it feels like we should able to use the retry logic built into the azure client if we tune it correctly. However, having spent more time than I care to reading the retry logic of the various cloud clients, there is some comfort in knowing the retry logic lives in CRDB code and is uniform. |
msbutler
approved these changes
Oct 14, 2025
| } | ||
| sp.SetTag("path", attribute.StringValue(object)) | ||
|
|
||
| if !opts.NoFileSize { |
There was a problem hiding this comment.
i wonder why you removed the NoFileSize logic here.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the azure client did not use the ResumingReader. This was causing tracing span use after free issues as the client would issue http retries with a span that was already finished. The ResumingReader manages a span for the lifetime of the reader.
There is also some evidence in #154483 that the RetryReader built into the azure client did not properly retry errors that occur while reading the body.
Fixes: #154849
Release note: none