ui: vendor NPM modules #27035
Merged
ui: vendor NPM modules #27035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM, but there should be some documentation about how to add/update packages here. Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained
|
Yeah, waiting on writing documentation until its proven that TeamCity can actually build with this. |
benesch
force-pushed
the
yarn-offline
branch
3 times, most recently
from
83a59e5
to
0ca81f6
Compare
|
Ok, TeamCity is happy! I've added instructions on how to manage dependencies in this new world. |
vilterp
approved these changes
Jun 28, 2018
|
|
||
| ```bash | ||
| $ cd yarn-vendor | ||
| $ git checkout -b YOURNAME/add-left-pad |
|
I had to Otherwise LGTM |
|
Hopefully just you! TeamCity and my GCE worker had no problem with it, for example. You didn't happen to save the error message, did you? |
|
|
Aha! Thanks. I know how to fix that. |
Vendor the NPM packages that our UI uses by checking them into a
submodule, github.com/cockroachdb/yarn-vendored. This prevents NPM or
Yarn registry flakiness from failing our CI builds, and also ensures
that a `git clone --recurse-submodules` is sufficient to build
CockroachDB offline.
The feature that enables this is Yarn's "offline mirror." The blog post
that introduced the feature also serves as its documentation:
https://yarnpkg.com/blog/2016/11/24/offline-mirror/
To ensure the offline mirror is really used, we pass the '--offline'
flag to all Yarn invocations in the build system.
Fix cockroachdb#14615.
Really fix cockroachdb#21432.
Release note: None
|
Ok, fixed. Merging! TFTRs. bors r=couchand,vilterp,bdarnell |
craig bot
pushed a commit
that referenced
this pull request
Jul 3, 2018
27035: ui: vendor NPM modules r=couchand,vilterp,bdarnell a=benesch Vendor the NPM packages that our UI uses by checking them into a submodule, [github.com/cockroachdb/yarn-vendored](https://github.com/cockroachdb/yarn-vendored). This prevents NPM or Yarn registry flakiness from failing our CI builds, and also ensures that a `git clone --recurse-submodules` is sufficient to build CockroachDB offline. The feature that enables this is Yarn's "offline mirror." The blog post that introduced the feature also serves as its documentation: https://yarnpkg.com/blog/2016/11/24/offline-mirror/ To ensure the offline mirror is really used, we pass the '--offline' flag to all Yarn invocations in the build system. Fix #14615. Really fix #21432. Release note: None Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Build succeeded |
benesch
added a commit
to benesch/cockroach
that referenced
this pull request
Oct 4, 2018
`yarn install` requires the yarn-vendor submodule to be available. This was missed when we started vendoring our Yarn dependencies in PR cockroachdb#27035. Fix cockroachdb#30619. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Oct 8, 2018
30993: build: check out submodules before yarn install r=couchand a=benesch `yarn install` requires the yarn-vendor submodule to be available. This was missed when we started vendoring our Yarn dependencies in PR #27035. Fix #30619. Release note: None Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
benesch
added a commit
to benesch/cockroach
that referenced
this pull request
Oct 15, 2018
`yarn install` requires the yarn-vendor submodule to be available. This was missed when we started vendoring our Yarn dependencies in PR cockroachdb#27035. Fix cockroachdb#30619. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the NPM packages that our UI uses by checking them into a
submodule, github.com/cockroachdb/yarn-vendored. This prevents NPM or
Yarn registry flakiness from failing our CI builds, and also ensures
that a
git clone --recurse-submodulesis sufficient to buildCockroachDB offline.
The feature that enables this is Yarn's "offline mirror." The blog post
that introduced the feature also serves as its documentation:
To ensure the offline mirror is really used, we pass the '--offline'
flag to all Yarn invocations in the build system.
Fix #14615.
Really fix #21432.
Release note: None