cli: use pretty-formatted tables only with terminals or --pretty.

[knz]

Prior to this patch all commands reporting table results would
print them using ASCII art tables (pretty-formatted). This makes
the output difficult to parse in automated scripts etc.

This patch corrects the behavior by using TSV output when the command
is not used from an interactive terminal. The pretty-formatted output
can be forced for non-terminal use using the command-line argument
--pretty.

---

This change is

[tamird]

Reviewed 7 of 8 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks pending.

---

cli/cli.go, line 66 [r2] (raw file):

// isInteractive indicates whether both stdin and stdout refer to the
// terminal.
var isInteractive bool

you can put the initialization inline here.

var isInteractive = isatty.....

---

cli/context.go, line 57 [r2] (raw file):

type sqlContext struct {
  // Embed the cli context.
  *cliContext

this should not be a pointer

---

cli/flags.go, line 447 [r2] (raw file):

      // By default, client commands print their output as
      // pretty-formatted tables on terminals, and TSV when redirected
      // to a file. The user can override with --pretty.  We set the

double space

---

cli/flags.go, line 519 [r2] (raw file):

      // Automatically print pretty-printed tables on interactive
      // terminals.
      cliCtx.prettyFmt = cliCtx.prettyFmt || isInteractive

this doens't handle the case of a user wanting non-pretty tables on the CLI with --pretty=false.

---

Comments from Reviewable

[knz]

Review status: 5 of 8 files reviewed at latest revision, 4 unresolved discussions, some commit checks pending.

---

cli/cli.go, line 66 [r2] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

you can put the initialization inline here.

var isInteractive = isatty.....

Done.

---

cli/context.go, line 57 [r2] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

this should not be a pointer

I believe it should; otherwise the changes performed to the global cliCtx by the flag logic will not be visible from sqlCtx.

---

cli/flags.go, line 447 [r2] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

double space

Done.

---

cli/flags.go, line 519 [r2] (raw file):

Previously, tamird (Tamir Duberstein) wrote…

this doens't handle the case of a user wanting non-pretty tables on the CLI with --pretty=false.

Done.

---

Comments from Reviewable

[tamird]

---

Reviewed 3 of 3 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.

---

Comments from Reviewable