Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow starting docker container via env variable #98899

Merged
merged 1 commit into from Mar 30, 2023

Conversation

btkostner
Copy link
Contributor

@btkostner btkostner commented Mar 17, 2023

Fixes #87043 by allowing you to specify args via the COCKROACH_ARGS env value instead of a command. This is required to be able to use the official cockroach image with GitHub actions via a service. More details in the issue.

Note, do to weirdness with merging commands and env values, I decided that setting the COCKROACH_ARGS would ignore any command given. This should reduce issues with people trying to use both ways of specifying args and instead force them to pick one.

Release note (general change): Allow setting docker command args via the COCKROACH_ARGS environment variable.

@btkostner btkostner requested a review from a team as a code owner March 17, 2023 22:09
@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 17, 2023

CLA assistant check
All committers have signed the CLA.

@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2023

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Mar 17, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (general change): Allow setting docker command args via the `COCKROACH_ARGS` environment variable.
@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2023

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@rickystewart
Copy link
Collaborator

Thanks for the contribution!

bors r+

@craig craig bot merged commit 331a672 into cockroachdb:master Mar 30, 2023
3 of 4 checks passed
@craig
Copy link
Contributor

craig bot commented Mar 30, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing arguments to the docker image as env var
3 participants