-
Notifications
You must be signed in to change notification settings - Fork 473
Surface core value props in start a cluster #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bdarnell, @spencerkimball, would appreciate your feedback, too. |
Review status: 0 of 6 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
@asubiotto, can you please check the Stop the cluster step? |
302c837
to
129a842
Compare
Reviewed 6 of 6 files at r1. start-a-local-cluster.md, line 48 at r1 (raw file):
nit: maybe "out of memory" or out-of-memory Comments from Reviewable |
Review status: 5 of 6 files reviewed at latest revision, 4 unresolved discussions. start-a-local-cluster.md, line 76 at r2 (raw file):
Typo: cleint start-a-local-cluster.md, line 81 at r2 (raw file):
Should we mention that the start-a-local-cluster.md, line 192 at r2 (raw file):
As an alternative to this slightly complicated process, we could recommend that they run all three nodes without Comments from Reviewable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So so great. Thank you, @jseldess !
Review status: 5 of 6 files reviewed at latest revision, 4 unresolved discussions. start-a-local-cluster.md, line 48 at r1 (raw file): Previously, sploiselle (Sean Loiselle) wrote…
Done. start-a-local-cluster.md, line 76 at r2 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Done. start-a-local-cluster.md, line 81 at r2 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Done. start-a-local-cluster.md, line 192 at r2 (raw file): Previously, bdarnell (Ben Darnell) wrote…
Running each node in a separate terminal does make this particular step a lot easier, I agree, but I think it complicates the process overall. All other steps feel a lot quicker in the same terminal. Also, I don't know whether I can get an asciicast to work across terminal windows... Comments from Reviewable |
129a842
to
baccec1
Compare
Love the called-out admin ui replication graph. 👍 |
baccec1
to
bdff823
Compare
bdff823
to
41ae4b6
Compare
These changes attempt to keep the Start a Cluster tutorial quick and easy while introducing new users to what makes CockroachDB unique, not just ease of deployment, but also automated replication and survival. I've also stripped out some details that I think are not important to the majority of users getting up and running for the first time, e.g., how to customize `start` flags and the fact that you can use third-party monitoring. Finally, I've update the Stop the Cluster step to account for the fact that `cockroach quit` can't be used to stop nodes once quorum is lost. Fixes #1191 Fixes #1252
41ae4b6
to
933e26f
Compare
fe2be66
to
1c84a40
Compare
* Create 'release/arangodb-3.9.8_23012715583603' for 3.9.8 release of ArangoDB * Update examples for 3.9 in release/arangodb-3.9.8_23012715583603 at 2023-01-27T16:25:33+00:00 --------- Co-authored-by: arangodb-release-bot <> Co-authored-by: arangodb-release-bot <vadim@arangodb.com>
These changes attempt to keep the Start a Cluster tutorial
quick and easy while introducing new users to what makes
CockroachDB unique, not just ease of deployment, but also
automated replication and survival.
I've also stripped out some details that I think are not
important to the majority of users getting up and running
for the first time, e.g., how to customize
start
flagsand the fact that you can use third-party monitoring.
Finally, I've update the Stop the Cluster step to account
for the fact that
cockroach quit
can't be used to stopnodes once quorum is lost.
This change is