Bring compilation down to ~4s #1477

benesch · 2017-05-30T21:14:40Z

See individual commits for details!

This change is

cockroach-teamcity · 2017-05-30T22:00:41Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/bdd84decc23601e9414b5abc77f20c167e0e421b/

cockroach-teamcity · 2017-05-31T04:23:13Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e4f772439b1bef61bec7514063e99f1548e91592/

madelynnblue

LGTM, with the caveat that I don't know any ruby.

cockroach-teamcity · 2017-05-31T13:06:30Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e4f772439b1bef61bec7514063e99f1548e91592/

jseldess · 2017-05-31T16:50:13Z

Don't see why this would have anything to do with your changes, but the hubspot email sign-up at the top of each release notes page is missing:

Compare that to the live page:

jseldess · 2017-05-31T16:49:58Z

_plugins/template_cache.rb

@@ -0,0 +1,16 @@
+module TemplateWithCaching


Can you add a comment to explain the purpose of this code?

I ended up just nuking that module; causing more problems than it solved.

jseldess · 2017-05-31T17:23:50Z

Haven't look through all pages, but so far, I've found these issues. Happy to help fix these.

On Install Client Drivers, the html comment is now visible for some reason.
On Constraints, some of the code blocks aren't getting indented properly.
On Data Types, the main table is broken, and the green tip isn't indented properly.
On SERIAL, the number and indentation are off here.
More code block and callout indentation issues on COLLATE.
On Recommended Production Settings, some anchor links, steps, and code blocks aren't rendering.

sploiselle · 2017-05-31T17:42:54Z

Railroad diagrams are broken (example)

cockroach-teamcity · 2017-06-02T17:51:25Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/686bdb1aa216b0a499fcdd678f02bee9e0da9b45/

cockroach-teamcity · 2017-06-02T18:19:35Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/230547593273265aad34cf2607cc28caf77c0ddb/

cockroach-teamcity · 2017-06-02T18:32:14Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/230547593273265aad34cf2607cc28caf77c0ddb/

cockroach-teamcity · 2017-06-02T18:37:34Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/b3fe65ca7226e4485ab89d749d21ce9dfc75fdc4/

benesch · 2017-06-02T18:53:50Z

Ok, I think I've fixed all the bugs you guys found! PTAL.

cockroach-teamcity · 2017-06-02T18:55:50Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/08637c07b4ce802362dce92332f0f58d8df59e9e/

cockroach-teamcity · 2017-06-02T19:14:05Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c1bfffbafb1b13ebd228ed05f13377c6796d9a5e/

cockroach-teamcity · 2017-06-02T19:34:13Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a32825cb597a08a4165716cb0bd09a337b6f75b4/

cockroach-teamcity · 2017-06-02T20:00:05Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cf4191e63f72fc32e4cc1410512d2020feb5d604/

cockroach-teamcity · 2017-06-02T20:01:49Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d369515756b78795f910a52a915429b551df1bac/

cockroach-teamcity · 2017-06-02T20:55:56Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0d438e2b2e539eb9f3adbb5a14af040e6c4a9966/

cockroach-teamcity · 2017-06-02T20:57:05Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8b4fe1c7b4f92851a9d0922d43038d92d07300fe/

benesch · 2017-06-02T21:04:42Z

This is finally green! 🎉

jseldess

LGTM, @benesch! Thanks for getting this to work. If @sploiselle also good with this, go ahead and merge.

Sidenote: On other PRs, Team City is failing on missing gems and a bundle file. Is that related to this PR. Will we just have to rebase those PRs once this is merged?

benesch · 2017-06-05T13:26:51Z

Eek, yep, my fault. Let me see if I can appease TeamCity so it works with and without this PR.

benesch · 2017-06-05T13:34:03Z

Ok! Ready when you are, @sploiselle.

sploiselle · 2017-06-05T14:45:19Z

Redcarpet's breaking on nested code blocks, e.g., Cluster Setup Troubleshooting.

Can we resolve this with changes to the markdown, or is it a Redcarpet issue?

sploiselle · 2017-06-05T14:48:25Z

Didn't realize my last comment was already tracked in #1492; do you want to do a fast-follow PR to fix these issues @jseldess? Otherwise, I'm glad to take it

jseldess · 2017-06-05T15:04:25Z

@benesch, Sean found another page where the indentation needs to be fixed up. Would you handle that real quick before merging? Otherwise, yeah, would be great if you'd follow up with a fix after merge, @sploiselle.

Markdown is a very loosely-specified format, so there are understandibly some differences in how parsers render the same Markdown file. Our new Markdown parser, redcarpet, is picker than our old parser, Kramdown, and insists on things like four spaces of indentation for paragraphs/code blocks in lists. This commit fixes several places where we were relying on Kramdown's heuristics to instead adhere to the Markdown standard.

Kramdown and Redcarpet generate href hashes slightly differently; adjust accordingly.

Now that we have four gem dependencies (jekyll, redcarpet, html-proofer, and rake), it's annoying to install each by hand. Re-add a Gemfile that lists our dependencies and versions. (The original Gemfile was removed to fix build issues in TeamCity; I'll just fix those.)

benesch · 2017-06-05T15:20:04Z

Oh, good catch! Should be fixed now.

cockroach-teamcity · 2017-06-05T15:22:27Z

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d3006ff6dca1ed8ee42d3028ef9ca43cc3b98b5f/

sploiselle · 2017-06-05T15:36:10Z

You are such a champ, @benesch

benesch · 2017-06-05T15:40:33Z

🍻

I broke this in cockroachdb#1477. Guess it wasn't "dead code."

benesch requested review from madelynnblue, jseldess and sploiselle May 30, 2017 21:14

benesch force-pushed the fast-compiles branch from e9993aa to bdd84de Compare May 30, 2017 21:15

benesch force-pushed the fast-compiles branch from bdd84de to e4f7724 Compare May 31, 2017 04:19

madelynnblue approved these changes May 31, 2017

View reviewed changes

jseldess reviewed May 31, 2017

View reviewed changes

benesch force-pushed the fast-compiles branch from e4f7724 to 686bdb1 Compare June 2, 2017 17:48

benesch force-pushed the fast-compiles branch from 686bdb1 to 2305475 Compare June 2, 2017 18:16

benesch force-pushed the fast-compiles branch from 2305475 to b3fe65c Compare June 2, 2017 18:34

benesch force-pushed the fast-compiles branch from b3fe65c to 08637c0 Compare June 2, 2017 18:53

benesch force-pushed the fast-compiles branch from 08637c0 to c1bfffb Compare June 2, 2017 19:09

benesch force-pushed the fast-compiles branch from c1bfffb to a32825c Compare June 2, 2017 19:31

benesch force-pushed the fast-compiles branch 2 times, most recently from cf4191e to d369515 Compare June 2, 2017 19:58

benesch force-pushed the fast-compiles branch 2 times, most recently from 0d438e2 to 8b4fe1c Compare June 2, 2017 20:54

jseldess approved these changes Jun 5, 2017

View reviewed changes

jseldess mentioned this pull request Jun 5, 2017

style guide: paragraphs/code blocks in a list item #1492

Closed

benesch added 5 commits June 5, 2017 11:18

switch to redcarpet markdown compiler for faster compiles

5d5b770

adjust href hashes for redcarpet's toc generation

9f9757a

Kramdown and Redcarpet generate href hashes slightly differently; adjust accordingly.

remove dead code

319a339

re-add Gemfile

d3006ff

Now that we have four gem dependencies (jekyll, redcarpet, html-proofer, and rake), it's annoying to install each by hand. Re-add a Gemfile that lists our dependencies and versions. (The original Gemfile was removed to fix build issues in TeamCity; I'll just fix those.)

benesch force-pushed the fast-compiles branch from 8b4fe1c to d3006ff Compare June 5, 2017 15:19

sploiselle approved these changes Jun 5, 2017

View reviewed changes

benesch merged commit bed4a05 into cockroachdb:gh-pages Jun 5, 2017

benesch deleted the fast-compiles branch June 5, 2017 15:40

benesch added a commit to benesch/docs that referenced this pull request Jun 30, 2017

fix mobile breadcrumbs

fe5640e

I broke this in cockroachdb#1477. Guess it wasn't "dead code."

benesch added a commit to benesch/docs that referenced this pull request Jun 30, 2017

fix mobile breadcrumbs

5667d86

I broke this in cockroachdb#1477. Guess it wasn't "dead code."

This was referenced Jun 30, 2017

fix mobile breadcrumbs #1652

Merged

fix mobile breadcrumbs, round two #1657

Merged

Bring compilation down to ~4s #1477

Bring compilation down to ~4s #1477

Uh oh!

Conversation

benesch commented May 30, 2017 • edited by andreimatei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cockroach-teamcity commented May 30, 2017

Uh oh!

cockroach-teamcity commented May 31, 2017

Uh oh!

madelynnblue left a comment

Choose a reason for hiding this comment

Uh oh!

cockroach-teamcity commented May 31, 2017

Uh oh!

jseldess commented May 31, 2017

Uh oh!

jseldess May 31, 2017

Choose a reason for hiding this comment

Uh oh!

benesch Jun 2, 2017

Choose a reason for hiding this comment

Uh oh!

jseldess commented May 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sploiselle commented May 31, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

benesch commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

cockroach-teamcity commented Jun 2, 2017

Uh oh!

benesch commented Jun 2, 2017

Uh oh!

jseldess left a comment

Choose a reason for hiding this comment

Uh oh!

benesch commented Jun 5, 2017

Uh oh!

benesch commented Jun 5, 2017

Uh oh!

sploiselle commented Jun 5, 2017

Uh oh!

sploiselle commented Jun 5, 2017

Uh oh!

jseldess commented Jun 5, 2017

Uh oh!

benesch commented Jun 5, 2017

Uh oh!

cockroach-teamcity commented Jun 5, 2017

Uh oh!

sploiselle commented Jun 5, 2017

Uh oh!

benesch commented Jun 5, 2017

Uh oh!

Uh oh!

benesch commented May 30, 2017 •

edited by andreimatei

Loading

jseldess commented May 31, 2017 •

edited

Loading