fix mobile breadcrumbs, round two #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pages which do not have a sidebar entry should render "Docs Menu" in the header, like the used to.
Addresses review feedback from cockroachdb#1652.
|
This change is |
|
(FWIW I tried doing it in three loops, but it got a lot more complicated as
measured by lines of code, and we're probably throwing this sidebar away
eventually: #1021)
…On Tue, Jul 4, 2017 at 3:04 PM Justin Jaffray ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1657 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA15IIJucSkD7-WqWHWBaC1hg9HyCFlWks5sKozDgaJpZM4ONlvB>
.
|
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile, properly render "Docs Menu" in the collapsed header on pages without a sidebar entry, like the homepage and search bar. This addresses additional breakage from #1477 that was not addressed by #1652.
Also address review feedback from #1652 by adding some documenting comments.