-
Notifications
You must be signed in to change notification settings - Fork 473
Updated Active Record support docs #7480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c1f90cb74a1405d7c00d972b49084e784a0e1ad3/ Edited pages: |
c1f90cb
to
e2c55b7
Compare
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e2c55b70355239d8bbdfaddf09b07c0ed6501a5c/ Edited pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @vy-ton)
_includes/v20.1/misc/tooling.md, line 33 at r1 (raw file):
| Java | [Hibernate](build-a-java-app-with-cockroachdb-hibernate.html)<hr>[jOOQ](build-a-java-app-with-cockroachdb-jooq.html) | [5.4](https://hibernate.org/orm/releases/)<hr>[3.13.2](https://www.jooq.org/download/versions) (must be 3.13.0 or higher) | Full<hr>Full | | Node.js | [Sequelize](build-a-nodejs-app-with-cockroachdb-sequelize.html) | [sequelize 5.21.9](https://www.npmjs.com/package/sequelize)<br>[sequelize-cockroachdb 1.1.0](https://www.npmjs.com/package/sequelize-cockroachdb) | Beta | | Ruby | [ActiveRecord](build-a-ruby-app-with-cockroachdb-activerecord.html) | [activerecord 5.2](https://rubygems.org/gems/activerecord)<br>[activerecord-cockroachdb-adpater 5.2.0](https://rubygems.org/gems/activerecord-cockroachdb-adapter) | Full |
For the activerecord
version, we should specify the 5.2.x version that we run tests against. @rafiss for your active record CI work, which 5.2.x version was being used.
@ericharmeling Just checked with Rafi, but the new adapter requires CRDB Following up on what adapter version we should use with CRDB 19.2 |
_includes/v20.1/misc/tooling.md
Outdated
| Java | [Hibernate](build-a-java-app-with-cockroachdb-hibernate.html)<hr>[jOOQ](build-a-java-app-with-cockroachdb-jooq.html) | [5.4](https://hibernate.org/orm/releases/)<hr>[3.13.2](https://www.jooq.org/download/versions) (must be 3.13.0 or higher) | Full<hr>Full | | ||
| Node.js | [Sequelize](build-a-nodejs-app-with-cockroachdb-sequelize.html) | [sequelize 5.21.9](https://www.npmjs.com/package/sequelize)<br>[sequelize-cockroachdb 1.1.0](https://www.npmjs.com/package/sequelize-cockroachdb) | Beta | | ||
| Ruby | [ActiveRecord](build-a-ruby-app-with-cockroachdb-activerecord.html) | [activerecord 5.2.4.2](https://rubygems.org/gems/activerecord)<br>[activerecord-cockroachdb-adpater 5.2.0.beta2](https://rubygems.org/gems/activerecord-cockroachdb-adapter) | Beta | | ||
| Ruby | [ActiveRecord](build-a-ruby-app-with-cockroachdb-activerecord.html) | [activerecord 5.2](https://rubygems.org/gems/activerecord)<br>[activerecord-cockroachdb-adpater 5.2.0](https://rubygems.org/gems/activerecord-cockroachdb-adapter) | Full | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can say Full as of v20.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Perhaps we could say that there's beta support for 19.2 with the new adapter? I believe it should work in general, it's just that we haven't run the full test suite against it because the tests themselves make heavy use of savepoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could say that there's beta support for 19.2 with the new adapter?
I believe it should work in general, it's just that we haven't run the full test suite against it because the tests themselves make heavy use of savepoints.
Done.
I made the updates you requested. See the changes in the latest commit. |
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/d1a49910a43f879c85c90fb08bc6506f9ce94c39/ Edited pages: |
LGTM! |
Fixes #7472.