Skip to content

Conversation

ericharmeling
Copy link
Contributor

Fixes #7472.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ericharmeling ericharmeling force-pushed the active-record-version-update branch from c1f90cb to e2c55b7 Compare June 8, 2020 15:11
@ericharmeling ericharmeling requested a review from vy-ton June 8, 2020 15:14
Copy link
Contributor

@vy-ton vy-ton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @vy-ton)


_includes/v20.1/misc/tooling.md, line 33 at r1 (raw file):

| Java | [Hibernate](build-a-java-app-with-cockroachdb-hibernate.html)<hr>[jOOQ](build-a-java-app-with-cockroachdb-jooq.html) | [5.4](https://hibernate.org/orm/releases/)<hr>[3.13.2](https://www.jooq.org/download/versions) (must be 3.13.0 or higher) | Full<hr>Full |
| Node.js | [Sequelize](build-a-nodejs-app-with-cockroachdb-sequelize.html) | [sequelize 5.21.9](https://www.npmjs.com/package/sequelize)<br>[sequelize-cockroachdb 1.1.0](https://www.npmjs.com/package/sequelize-cockroachdb) | Beta |
| Ruby | [ActiveRecord](build-a-ruby-app-with-cockroachdb-activerecord.html) | [activerecord 5.2](https://rubygems.org/gems/activerecord)<br>[activerecord-cockroachdb-adpater 5.2.0](https://rubygems.org/gems/activerecord-cockroachdb-adapter) | Full |

For the activerecord version, we should specify the 5.2.x version that we run tests against. @rafiss for your active record CI work, which 5.2.x version was being used.

@vy-ton
Copy link
Contributor

vy-ton commented Jun 8, 2020

@ericharmeling Just checked with Rafi, but the new adapter requires CRDB v20.1 due to savepoint support. We should highlight this on the tooling summary page and remove the 19.2 changes.

Following up on what adapter version we should use with CRDB 19.2

| Java | [Hibernate](build-a-java-app-with-cockroachdb-hibernate.html)<hr>[jOOQ](build-a-java-app-with-cockroachdb-jooq.html) | [5.4](https://hibernate.org/orm/releases/)<hr>[3.13.2](https://www.jooq.org/download/versions) (must be 3.13.0 or higher) | Full<hr>Full |
| Node.js | [Sequelize](build-a-nodejs-app-with-cockroachdb-sequelize.html) | [sequelize 5.21.9](https://www.npmjs.com/package/sequelize)<br>[sequelize-cockroachdb 1.1.0](https://www.npmjs.com/package/sequelize-cockroachdb) | Beta |
| Ruby | [ActiveRecord](build-a-ruby-app-with-cockroachdb-activerecord.html) | [activerecord 5.2.4.2](https://rubygems.org/gems/activerecord)<br>[activerecord-cockroachdb-adpater 5.2.0.beta2](https://rubygems.org/gems/activerecord-cockroachdb-adapter) | Beta |
| Ruby | [ActiveRecord](build-a-ruby-app-with-cockroachdb-activerecord.html) | [activerecord 5.2](https://rubygems.org/gems/activerecord)<br>[activerecord-cockroachdb-adpater 5.2.0](https://rubygems.org/gems/activerecord-cockroachdb-adapter) | Full |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can say Full as of v20.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rafiss
Copy link
Contributor

rafiss commented Jun 8, 2020

Perhaps we could say that there's beta support for 19.2 with the new adapter?

I believe it should work in general, it's just that we haven't run the full test suite against it because the tests themselves make heavy use of savepoints.

Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could say that there's beta support for 19.2 with the new adapter?

I believe it should work in general, it's just that we haven't run the full test suite against it because the tests themselves make heavy use of savepoints.

Done.

@ericharmeling
Copy link
Contributor Author

@vy-ton

I made the updates you requested. See the changes in the latest commit.

@vy-ton
Copy link
Contributor

vy-ton commented Jun 8, 2020

LGTM!

@ericharmeling ericharmeling requested a review from lnhsingh June 9, 2020 17:38
@ericharmeling ericharmeling merged commit 836e2c9 into master Jun 9, 2020
@ericharmeling ericharmeling deleted the active-record-version-update branch June 9, 2020 17:41
rmloveland added a commit that referenced this pull request Jun 11, 2020
@rmloveland rmloveland mentioned this pull request Jun 11, 2020
rmloveland added a commit that referenced this pull request Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Active Record tutorial to use new adapter version
5 participants