tests: use colon separator for KVs

The vast majority of tests that specify a KV use the `key:value`
format. The parsing code also supports using a `=` separator and a
handful of tests use that format.

For the sake of consistency, remove this alternate format and fix up
the relevant tests.

Author: RaduBerinde

replay/testdata/corpus/simple_ingest

@@ -12,19 +12,19 @@ build:
   marker.manifest.000001.MANIFEST-000001
 
 build-sst foo.sst
-a#0,SET = a
-b#0,SET = byaya
-c#0,SET = cyuumi
-d#0,SET = d
+a#0,SET:a
+b#0,SET:byaya
+c#0,SET:cyuumi
+d#0,SET:d
 ----
 
 ingest foo.sst
 ----
 ingested
 
 build-sst f.sst
-p#0,SET = p
-q#0,SET = q
+p#0,SET:p
+q#0,SET:q
 ----
 
 ingest-and-excise f.sst excise=a-d
@@ -64,16 +64,16 @@ simple_ingest/checkpoint:
   marker.manifest.000001.MANIFEST-000001
 
 build-sst loo.sst
-x#0,SET = x
-y#0,SET = y
+x#0,SET:x
+y#0,SET:y
 ----
 
 ingest loo.sst
 ----
 ingested
 
 build-sst l.sst
-z#0,SET = z
+z#0,SET:z
 ----
 
 ingest-and-excise l.sst excise=d-p

sstable/test_utils.go

@@ -130,23 +130,25 @@ func (kv ParsedKVOrSpan) String() string {
 	return fmt.Sprintf("%s%s = blob:%s attr=%d", prefix, kv.Key, kv.BlobHandle, kv.Attr)
 }
 
-// ParseTestKVsAndSpans parses a multi-line string that defines SSTable contents.
+// ParseTestKVsAndSpans parses a multi-line string that defines SSTable
+// contents.
 //
-// The blobtest.Values argument can be nil if there are no blob references in the input.
+// The blobtest.Values argument can be nil if there are no blob references in
+// the input.
 //
 // Each input line can be either a key-value pair or a key spans Sample input
 // showing the format:
 //
-//	a#1,SET = a
-//	force-obsolete: d#2,SET = d
-//	f#3,SET = blob{fileNum=1 blockNum=2 offset=110 valueLen=200}attr=7
+//	a#1,SET:a
+//	force-obsolete: d#2,SET:d
+//	f#3,SET:blob{fileNum=1 blockNum=2 offset=110 valueLen=200}attr=7
 //	Span: d-e:{(#4,RANGEDEL)}
 //	Span: a-d:{(#11,RANGEKEYSET,@10,foo)}
 //	Span: g-l:{(#5,RANGEDEL)}
 //	Span: y-z:{(#12,RANGEKEYSET,@11,foo)}
 //
-// Note that the older KV format "<user-key>.<kind>.<seq-num> : <value>" is also supported
-// (for now).
+// Note that the older key format "<user-key>.<kind>.<seq-num>" is also
+// supported (for now).
 func ParseTestKVsAndSpans(input string, bv *blobtest.Values) (_ []ParsedKVOrSpan, err error) {
 	defer func() {
 		if r := recover(); r != nil {
@@ -163,10 +165,10 @@ func ParseTestKVsAndSpans(input string, bv *blobtest.Values) (_ []ParsedKVOrSpan
 
 		var kv ParsedKVOrSpan
 		line, kv.ForceObsolete = strings.CutPrefix(line, "force-obsolete:")
-		// Cut the key at the first ":" or "=".
-		sepIdx := strings.IndexAny(line, "=:")
+		// Cut the key at the first ":".
+		sepIdx := strings.Index(line, ":")
 		if sepIdx == -1 {
-			return nil, errors.Newf("KV format is [force-obsolete:] <key>=<value> (or <key>:<value>): %q", line)
+			return nil, errors.Newf("KV format is \"[force-obsolete:] <key>:<value>\": %q", line)
 		}
 		keyStr := strings.TrimSpace(line[:sepIdx])
 		valStr := strings.TrimSpace(line[sepIdx+1:])

testdata/compaction_corruption

@@ -1,7 +1,7 @@
 build-remote file-not-there
-d#0,SET = dvalue
-q#0,SET = qvalue
-w#0,SET = wvalue
+d#0,SET:dvalue
+q#0,SET:qvalue
+w#0,SET:wvalue
 ----
 
 ingest-external
@@ -31,9 +31,9 @@ wait-for-no-external-files workload=(d,w)
 ----
 
 build-remote file2-not-there
-a#0,SET = avalue
-u#0,SET = uvalue
-z#0,SET = zvalue
+a#0,SET:avalue
+u#0,SET:uvalue
+z#0,SET:zvalue
 ----
 
 ingest-external

testdata/disk_usage

@@ -92,11 +92,11 @@ total: 1358, remote: 0, external: 0
 
 # Test with remote files and external files
 build-remote ext2 block-size=10 index-block-size=10
-k#0,SET = foo
-l#0,SET = foo
-m#0,SET = foo
-n#0,SET = foo
-o#0,SET = foo
+k#0,SET:foo
+l#0,SET:foo
+m#0,SET:foo
+n#0,SET:foo
+o#0,SET:foo
 ----
 
 estimate-disk-usage-by-backing-type a z

testdata/excise

@@ -737,9 +737,9 @@ L6:
 # We set the block size to prevent randomization of block sizes (which affects
 # the size).
 build-remote remote1 block-size=1024 index-block-size=1024
-g#0,SET = foo
-h#0,SET = bar
-i#0,SET = foobar
+g#0,SET:foo
+h#0,SET:bar
+i#0,SET:foobar
 ----
 
 ingest-external
@@ -776,9 +776,9 @@ L6:
 # Non-local tables are excised without data access.
 
 build-remote remote2
-u#0,SET = foo
-v#0,SET = bar
-w#0,SET = foobar
+u#0,SET:foo
+v#0,SET:bar
+w#0,SET:foobar
 ----
 
 ingest-external

testdata/excise_bounds

@@ -1,8 +1,8 @@
 build-sst
-b#1,SET = b
-c#1,SET = c
-d#1,SET = d
-e#1,SET = e
+b#1,SET:b
+c#1,SET:c
+d#1,SET:d
+e#1,SET:e
 ----
 Bounds:
   overall: b#1,SET - e#1,SET
@@ -135,9 +135,9 @@ Right table bounds (loose):
 
 # Test with a RANGEDEL.
 build-sst
-b#1,SET = b
-cc#1,SET = cc
-e#1,SET = e
+b#1,SET:b
+cc#1,SET:cc
+e#1,SET:e
 Span: c-d:{(#2,RANGEDEL)}
 ----
 Bounds:
@@ -198,9 +198,9 @@ Left table bounds (loose):
 # Test with range keys.
 
 build-sst
-b#1,SET = b
-cc#1,SET = cc
-e#1,SET = e
+b#1,SET:b
+cc#1,SET:cc
+e#1,SET:e
 Span: c-d:{(#2,RANGEKEYSET,@10,foo)}
 ----
 Bounds: