bytesprofile: bump stack depth

jbowens · jbowens · commit 727d3e670a15 · 2025-11-17T16:04:15.000-05:00
Bump the maximum stack depth sampled from 20 frames to 30. We've observed that
we could use more depth in Cockroach stack traces, as we're unable to see where
a batch evaluation originated even if it's run on the same node.
diff --git a/internal/bytesprofile/bytesprofile.go b/internal/bytesprofile/bytesprofile.go
@@ -28,7 +28,7 @@ func NewProfile() *Profile {
 	return &Profile{samples: make(map[stack]aggSamples)}
 }
 
-type stack [20]uintptr
+type stack [30]uintptr
 
 // trimmed returns the non-zero stack frames of stack.
 func (s stack) trimmed() []uintptr {

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ func NewProfile() *Profile {`
`28`	`28`	`return &Profile{samples: make(map[stack]aggSamples)}`
`29`	`29`	`}`
`30`	`30`
`31`		`-type stack [20]uintptr`
	`31`	`+type stack [30]uintptr`
`32`	`32`
`33`	`33`	`// trimmed returns the non-zero stack frames of stack.`
`34`	`34`	`func (s stack) trimmed() []uintptr {`