V3 Layout scissors clipping mode fix #18651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevetranby
added a commit
to stevetranby/cocos2d-x
that referenced
this pull request
Jan 29, 2018
|
@minggo @dumganhar please look here |
|
Is there any test case to reproduce it? |
|
Yes see pull request |
|
@minggo This fix is better than the one I recently submitted in #20352 and #20407 and actually addresses a few more issues with the clipping. It should replace the ones I submitted. I'll submit a new V4 PR with this same code, but it's best if the changes in this PR are used for V3 since it's already here. |
rh101
added a commit
to rh101/cocos2d-x
that referenced
this pull request
Dec 16, 2019
minggo
approved these changes
Dec 16, 2019
|
Yep, i don't know why i missed this PR. |
minggo
pushed a commit
that referenced
this pull request
Jan 6, 2020
|
@rh101 you are appreciated if you can send a new PR. |
|
Will do so today |
Xrysnow
pushed a commit
to Xrysnow/cocos2d-x
that referenced
this pull request
Jun 21, 2020
* Fix for issue cocos2d#19890 * Updated with better fix from the V3 PR cocos2d#18651 * Formatting fix * Fixed issue with incorrect type (double instead of float) when compiling on certain platforms. * Another attempt to fix compilation issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bugs in Layout scissors clipping mode