Update index action for Organization MEmberships

Author: npendery

web/controllers/organization_membership_controller.ex

@@ -8,38 +8,55 @@ defmodule CodeCorps.OrganizationMembershipController do
 
   plug :scrub_params, "data" when action in [:create, :update]
 
-  def index(conn, %{"filter" => %{"id" => id_list}}) do
-    ids = id_list |> coalesce_id_string
+  def index(conn, params) do
     memberships =
-      OrganizationMembership
-      |> preload([:organization, :member])
-      |> where([p], p.id in ^ids)
-      |> Repo.all
+      case params do
+        %{"organization_id" => organization_id, "role" => roles, "filter" => id_list} ->
+          roles = roles |> coalesce_string
+          ids = id_list |> coalesce_id_string
+          OrganizationMembership
+            |> where([om], om.organization_id == ^organization_id)
+            |> where([om], om.member_id in ^ids)
+            |> where([om], om.role in ^roles)
+        %{"organization_id" => organization_id, "role" => roles} ->
+          roles = roles |> coalesce_string
+          OrganizationMembership
+            |> where([om], om.organization_id == ^organization_id)
+            |> where([om], om.role in ^roles)
+        %{"organization_id" => organization_id, "filter" => id_list} ->
+          id_list = id_list |> coalesce_id_string
+          OrganizationMembership
+            |> where([om], om.organization_id == ^organization_id)
+            |> where([om], om.id in ^id_list)
+        %{"role" => roles, "filter" => id_list} ->
+          roles = roles |> coalesce_string
+          ids = id_list |> coalesce_id_string
+          OrganizationMembership
+            |> where([om], om.member_id in ^ids)
+            |> where([om], om.role in ^roles)
+        %{"organization_id" => organization_id} ->
+          OrganizationMembership
+            |> where([om], om.organization_id == ^organization_id)
+        %{"filter" => id_list} ->
+          ids = id_list |> coalesce_id_string
+          OrganizationMembership
+            |> where([om], om.member_id in ^ids)
+        %{"role" => roles} ->
+          roles = roles |> coalesce_string
+          OrganizationMembership
+            |> where([om], om.role in ^roles)
+        _ ->
+          OrganizationMembership
+      end
 
-    render(conn, "index.json-api", data: memberships)
-  end
-
-  def index(conn, %{"role" => roles}) do
-    roles = roles |> coalesce_string
     memberships =
-      OrganizationMembership
+      memberships
       |> preload([:organization, :member])
-      |> where([p], p.role in ^roles)
       |> Repo.all
 
     render(conn, "index.json-api", data: memberships)
   end
 
-  def index(conn, %{"organization_id" => organization_id}) do
-    memberships =
-      OrganizationMembership
-        |> preload([:organization, :member])
-        |> where([m], m.organization_id == ^organization_id)
-        |> Repo.all
-
-    render(conn, "index.json-api", data: memberships)
-  end
-
   def show(conn, %{"id" => id}) do
     membership =
       OrganizationMembership