chore(package): update ember-cli-page-object to version 1.14.1 #1709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one, primarily due to changes in the
ember-cli-page-object
public APIThe major things I had to change to avoid deprecations:
page.render
is deprecated, sothis.render
has to be used. That means I had to get rid of therenderPage
function in all of our tests. The loss is that there is some code duplication now, but the gain is that the tests are far more explicit and easier to read throughcollection
API has changeditems().count
is nowitems.length
items(index).foo
is nowitems.objectAt(index).foo
the collection definition changed from
to