Skip to content

Conversation

begedin
Copy link
Contributor

@begedin begedin commented Mar 6, 2018

This is a big one, primarily due to changes in the ember-cli-page-object public API

The major things I had to change to avoid deprecations:

  • page.render is deprecated, so this.render has to be used. That means I had to get rid of the renderPage function in all of our tests. The loss is that there is some code duplication now, but the gain is that the tests are far more explicit and easier to read through

  • collection API has changed

    • items().count is now items.length
    • items(index).foo is now items.objectAt(index).foo
  • the collection definition changed from

items: collection({
  scope: '.foo',
  itemScope: '.bar',
  item: itemDefinitionObject
})

to

items: collection('.foo .bar', itemDefinitionObject)

Closes #1227

- perform package update
- clear out deprecations
@begedin begedin force-pushed the greenkeeper/ember-cli-page-object-1.14.1 branch from 871bd84 to 5e70676 Compare March 6, 2018 14:55
@begedin begedin merged commit 852e394 into develop Mar 7, 2018
@begedin begedin deleted the greenkeeper/ember-cli-page-object-1.14.1 branch March 7, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant