DTL (Test > Levelbuilder): 47d176a2 #36786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 56a8af1.
This reverts commit f6a1c48.
to include Hora del Código
In summary: we no longer lose the helper when rotating an iPhone from landscape to portrait in an AI for Oceans level. In an AI for Oceans level, when rotating an iPhone from landscape to portrait, the helper was being hidden, and would no longer be seen once rotated back to landscape, nor indeed for another year due to the cookie being set. This was because we were getting both an "orientationchange" event and a "resize" event, and the heuristic for determining whether the toolbar was hidden thought it had been hidden in the first event (specifically, window.innerHeight was equal to document.body.offsetHeight), while it wouldn't have thought it was dismissed in the second event. We only need to respond to the second, "resize", event, and things work better. A regular Flappy level appears to continue working. This also adds support for iOS 14. Followup to #34390
Missed a change.
Refactor iOS version checking.
This reverts commit 9959b02.
Removed reliance on hard-coded value for png size
DTT (Staging > Test) [robo-dtt]
CB -> LB : Create ActivityEditor for Lesson Edit Page
Hour of Code Date Helper: Try to use detected language
Create and Set Up Add level dialog for Activities Editor GUI
Remove lockable script edit
Upgrade to latest version of Drone server
"Hide Toolbar" Helper updates
…tring Update trademark string in hourofcode.com footer
DTS (Levelbuilder > Staging) [robo-dts]
DTT (Staging > Test) [dave]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.