Redirect donors 2 #47587
Redirect donors 2 #47587
Conversation
|
|
||
| if default_random_donor && !donor_name | ||
| donor = CdoDonor.get_random_donor_by_weight | ||
| donor = PegasusCdoDonor.get_random_donor_by_weight |
There was a problem hiding this comment.
hey @pablo-code-org , the challenge here is that certificate_image.rb is used by both pegasus and dashboard. Due to some quirks in the way we run pegasus locally and in drone, I have some concerns about this particular change sneaking through drone but then breaking in the DTT. If you want to proceed with this, I would suggest spinning up an adhoc and making sure the hour_of_code_finish.feature UI test is passing there.
alternately, what we had talked about at the end of last week was putting this change on hold until the congrats work is done, which I am planning to complete in the next few weeks.
There was a problem hiding this comment.
Oh, I'll leave the PR ready and wait for the image certificate changes
|
@pablo-code-org @davidsbailey Did the blocking work get completed and is this ready to be picked back up? |
|
@cat5inthecradle no, the blocking work is still in progress, currently actively being worked on. |
|
I got eager and merged latest staging (including the blocking congrats changes) into this PR 😝 after resolving merge conflicts and changing one |
Conflicts: dashboard/app/helpers/application_helper.rb
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: