Gen AI: separate "publish" and "save" buttons when filling out model card #57949

bencodeorg · 2024-04-11T00:02:23Z

Warning!!

The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.

Description

A few related updates related to splitting the "Publish" button in the "Publish" tab into separate "Publish" and "Save" buttons:

"Save" will save your model card info to S3 (and allows saving incomplete information).
A status bar tells you whether you need to fill out the card, or if you're ready to publish.
We hide the presentation/edit mode toggle until...
You've clicked the "publish" button, which is disabled until you've filled out the card. We set your model to published (via the new hasPublished state), and show the toggle at that point.
If you go back to the edit view and save your model card into an incomplete state, we hide the presentation toggle until you've filled out a valid model card again. I chatted about this flow with
Hide the "Publish" tab if a levelbuilder has configured hiding presentation toggle, since it doesn't really make sense to allow publishing if you can't view the presentation view.

publish-and-save-buttons.mov

Testing story

Tested manually -- see video above. Also tested that changing the hide presentation view setting in levelbuilder resulted in the "Publish" tab being hidden.

Follow-up work

A couple follow-ups I can think of:

I currently have hasPublished not being saved to S3 (ie, state does not persist between page loads). We need to update this, but I couldn't quite figure out whether to add it as part of the AiCustomizations type, or store it separately. In any case, it felt like we could do it as a fast follow.
I also think we probably want to distinguish in the notifications that go to the chat window between "publishing" and a saved update to some field in the model card. I can implement that in conjunction with the other follow-up above.

bencodeorg · 2024-04-11T19:01:13Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

-    () => dispatch(updateAiCustomization()),
-    [dispatch]
-  );
+  const onSave = useCallback(() => {


These multiple dispatches I believe are not the right way to do this, so looking for input :)

I see we have a couple instances where we put some redux updates that we want to happen after some async operation in this structure:

code-dot-org/apps/src/aichat/redux/aichatRedux.ts

Lines 318 to 331 in 194f7f0

extraReducers: builder => {

builder.addCase(submitChatMessage.fulfilled, state => {

state.isWaitingForChatResponse = false;

});

builder.addCase(submitChatMessage.rejected, (state, action) => {

state.isWaitingForChatResponse = false;

state.chatMessageError = true;

console.error(action.error);

});

builder.addCase(submitChatMessage.pending, state => {

state.isWaitingForChatResponse = true;

});

},

});

We also dispatch some redux actions inside of the thunk here:

code-dot-org/apps/src/aichat/redux/aichatRedux.ts

Lines 120 to 139 in 194f7f0

thunkAPI.dispatch(

setPreviouslySavedAiCustomizations(trimmedCurrentAiCustomizations)

);

const changedProperties = findChangedProperties(

previouslySavedAiCustomizations,

trimmedCurrentAiCustomizations

);

changedProperties.forEach(property => {

thunkAPI.dispatch(

addChatMessage({

id: 0,

role: Role.MODEL_UPDATE,

chatMessageText:

AI_CUSTOMIZATIONS_LABELS[property as keyof AiCustomizations],

status: Status.OK,

timestamp: getCurrentTime(),

})

);

});

Is one of these preferable? Is there a difference? Skimming through docs here, it seems like the first approach might be more standard?

https://redux-toolkit.js.org/api/createAsyncThunk

Seems like either approach is reasonable but defer to @sanchitmalhotra126 on a preference.

Yeah, I mean nothing wrong with back to back dispatches as such, but if the goal here is that we only update the publish state after saving has completed, we should move this into the async thunk. In fact, if we need to save the publish state to the project, it might actually be better to do this in the opposite order - on clicking save, if the model card is not filled out, set hasPublished to false so that when you do save, that value is saved to the project.

Check out the updates in the last two commits...there's at least one thing to figure out (I have an any in there 😬 ), but I tried to refactor to use async thunks. I don't see the approach I have here (a shared bit of async code that takes in thunkAPI as an arg), which usually isn't good. LMK what you think!

apps/src/aichat/redux/aichatRedux.ts

fisher-alice

Nice updates! Just left a couple questions and one being a more of a product question. Thanks!

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

fisher-alice · 2024-04-12T04:24:44Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+      <div>
+        {hasFilledOutModelCard(modelCardInfo)
+          ? renderPublishOkNotification()
+          : renderCompleteToPublishNotification()}


Not sure if this is what others would expect, but it seems like once the model card is published the first time, that unless the model card is modified so that one of the fields is no longer filled out, it remains published but can be updated.

This implementation seems to imply that if a user publishes, and then updates the model card, the model card is then unpublished since message states 'Ready to publish'. Or if the user publishes then refreshes the browser, the model card is no longer published. Is that the intention? This is probably more of a product question @samantha-code .

Yeah good question, it's definitely a bit confusing. I was chatting with Sam about this yesterday and we were struggling a bit to come up with the right solution. Not sure I have the exact right answer, but I think we felt like this was "close enough" and we'd interate.

Do you think if we had different status messages based on whether you have a currently published model or not would be the right path? eg, "Ready to update published model" and "In order to update your published model, you must complete the model card"?

I defer to @samantha-code but I think that different status messages would be helpful to the user.

I see Sanchit suggested making this a separate component #57949 (comment)
If this was a separate component, we could also add a warning for RetrievalCustomization when a user adds/deletes a retrieval but still has to update/save.

fisher-alice · 2024-04-12T14:22:14Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  const onPublish = useCallback(() => {
+    dispatch(updateAiCustomization());
+    dispatch(setHasPublished(true));
+    dispatch(setViewMode(ViewMode.PRESENTATION));


When the user clicks on 'Publish' and then the 'User View' is displayed, I imagine that the user may want to immediately update Model Card fields and click on 'Edit Mode'. What do you think about saving state so that the 'Publish' tab and not 'Setup' remains open to encourage an iterative process? Also related to comment below, that 'User View' remains displayed?

What do you think about saving state so that the 'Publish' tab and not 'Setup' remains open to encourage an iterative process?

I think that makes sense! Currently, we don't manage the selected tab in redux, and the Tabs component I think would need to refactored to manage the selected tab as a prop. We also should probably switch over to using Denys's new Tabs component rather than my home baked one. Would it be ok to do that as a follow-up?

Also related to comment below, that 'User View' remains displayed?

Not sure I'm following this part, happy to chat offline if easier!

That would be great as a follow-up and +1 on using Denys's new Tabs component - thanks!

Also related to comment below, that 'User View' remains displayed?
Not sure I'm following this part, happy to chat offline if easier!

Ah sorry. I think once we save hasPublished to sources, this will not be an issue when a user moves from level to level. I think I was referring to how when a model card has been published, the toggle remain visible.

fisher-alice · 2024-04-12T14:25:03Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

-    () => dispatch(updateAiCustomization()),
-    [dispatch]
-  );
+  const onSave = useCallback(() => {


Seems like either approach is reasonable but defer to @sanchitmalhotra126 on a preference.

apps/src/aichat/views/AichatView.tsx

sanchitmalhotra126

Nice work, this UI looks great! A few comments but nothing major.

One thing to consider in a follow-up maybe - what happens if you click publish and save back to back? Do we kick off two simultaneous saves? I don't think that's a huge deal, but it might be good to look into disabling one or the other button while a save is in progress?

apps/src/aichat/views/AichatView.tsx

sanchitmalhotra126 · 2024-04-12T16:47:12Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

-    () => dispatch(updateAiCustomization()),
-    [dispatch]
-  );
+  const onSave = useCallback(() => {


Yeah, I mean nothing wrong with back to back dispatches as such, but if the goal here is that we only update the publish state after saving has completed, we should move this into the async thunk. In fact, if we need to save the publish state to the project, it might actually be better to do this in the opposite order - on clicking save, if the model card is not filled out, set hasPublished to false so that when you do save, that value is saved to the project.

sanchitmalhotra126 · 2024-04-12T16:48:56Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  return property === 'botName' ? 'input' : 'textarea';
+};
+
+const hasFilledOutModelCard = (modelCardInfo: ModelCardInfo) => {


Would be good to move this to a selector in aichatRedux since it's a state computation that directly drives some UI

Done (I think), LMK if this looks ok!

sanchitmalhotra126 · 2024-04-12T16:51:41Z

apps/src/aichat/views/presentation/PresentationView.tsx

-  const currentAiCustomizations = useAppSelector(
-    state => state.aichat.currentAiCustomizations
+  const previouslySavedAiCustomizations = useAppSelector(
+    state => state.aichat.previouslySavedAiCustomizations
  );
  const {systemPrompt, temperature, retrievalContexts} =
-    currentAiCustomizations;
-  const modelCardInfo = currentAiCustomizations.modelCardInfo;
+    previouslySavedAiCustomizations;
+  const modelCardInfo = previouslySavedAiCustomizations.modelCardInfo;


nit: could collapse this into const {systemPrompt, temperature, retrievalContexts, modelCardInfo} = useAppSelector(state => state.aichat.previouslySavedAiCustomizations);?

Sure looks like it, done!

bencodeorg

Just pushed a couple commits, LMK what y'all think!

apps/src/aichat/redux/aichatRedux.ts

bencodeorg · 2024-04-12T18:24:43Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+      <div>
+        {hasFilledOutModelCard(modelCardInfo)
+          ? renderPublishOkNotification()
+          : renderCompleteToPublishNotification()}


Do you think if we had different status messages based on whether you have a currently published model or not would be the right path? eg, "Ready to update published model" and "In order to update your published model, you must complete the model card"?

bencodeorg · 2024-04-12T18:55:39Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  return property === 'botName' ? 'input' : 'textarea';
+};
+
+const hasFilledOutModelCard = (modelCardInfo: ModelCardInfo) => {


Done (I think), LMK if this looks ok!

bencodeorg · 2024-04-12T18:56:33Z

apps/src/aichat/views/presentation/PresentationView.tsx

-  const currentAiCustomizations = useAppSelector(
-    state => state.aichat.currentAiCustomizations
+  const previouslySavedAiCustomizations = useAppSelector(
+    state => state.aichat.previouslySavedAiCustomizations
  );
  const {systemPrompt, temperature, retrievalContexts} =
-    currentAiCustomizations;
-  const modelCardInfo = currentAiCustomizations.modelCardInfo;
+    previouslySavedAiCustomizations;
+  const modelCardInfo = previouslySavedAiCustomizations.modelCardInfo;


Sure looks like it, done!

bencodeorg · 2024-04-12T19:04:17Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  const onPublish = useCallback(() => {
+    dispatch(updateAiCustomization());
+    dispatch(setHasPublished(true));
+    dispatch(setViewMode(ViewMode.PRESENTATION));


What do you think about saving state so that the 'Publish' tab and not 'Setup' remains open to encourage an iterative process?

I think that makes sense! Currently, we don't manage the selected tab in redux, and the Tabs component I think would need to refactored to manage the selected tab as a prop. We also should probably switch over to using Denys's new Tabs component rather than my home baked one. Would it be ok to do that as a follow-up?

Also related to comment below, that 'User View' remains displayed?

Not sure I'm following this part, happy to chat offline if easier!

apps/src/aichat/views/AichatView.tsx

bencodeorg · 2024-04-12T21:19:01Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

-    () => dispatch(updateAiCustomization()),
-    [dispatch]
-  );
+  const onSave = useCallback(() => {


Check out the updates in the last two commits...there's at least one thing to figure out (I have an any in there 😬 ), but I tried to refactor to use async thunks. I don't see the approach I have here (a shared bit of async code that takes in thunkAPI as an arg), which usually isn't good. LMK what you think!

sanchitmalhotra126

Looks good, nice refactoring! A few more small comments

sanchitmalhotra126 · 2024-04-13T00:19:16Z

apps/src/aichat/redux/aichatRedux.ts

+);
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+const updateAiCustomizationShared = async (thunkAPI: any) => {


nit: maybe rename to updateAndSaveAiCustomizations or just saveAiCustomizations? Also I think if you just pass in state and dispatch as separate args, you should be able to get rid of the any? Maybe even reduce down to just the specific state fields you need (current/previousAiCustomizations). We have a similar pattern in Lab2 where different async thunks make use of common shared functions, and just pass in the specific data they need from the thunkApi. Ex:

code-dot-org/apps/src/lab2/lab2Redux.ts

Lines 388 to 396 in f0320b0

function setProjectAndLevelData(

data: {

levelProperties: LevelProperties;

channel?: Channel;

initialSources?: ProjectSources;

},

aborted: boolean,

dispatch: ThunkDispatch<unknown, unknown, AnyAction>

) {

nit: maybe rename to updateAndSaveAiCustomizations or just saveAiCustomizations?

+1 on saveAiCustomizations

Updated here -- went with saveAiCustomization for the thunk that is exported, and saveAiCustomizationShared for the shared code since it aligns exactly with what happens when you use saveAiCustomization. LMK if that works for y'all!

a180faa

It seems like saveAiCustomizationShared is similar to an internal or private function. Is there a convention we could establish for these 'shared' functions that are used internally? 'Shared 'seems to have multiple meanings so may be a little unclear to a reader.

sanchitmalhotra126 · 2024-04-13T00:24:00Z

apps/src/aichat/redux/aichatRedux.ts

+const selectModelCardInfo = (state: {aichat: AichatState}) =>
+  state.aichat.currentAiCustomizations.modelCardInfo;
+
+export const selectHasFilledOutModelCard = createSelector(


TIL about createSelector!

sanchitmalhotra126 · 2024-04-13T00:24:40Z

apps/src/aichat/redux/aichatRedux.ts

+};
+
+// Selectors
+const selectModelCardInfo = (state: {aichat: AichatState}) =>


Does this need to be a separate selector or could this just be declared inline in selectHasFilledOutModelCard?

I think inline is fine, I was inspired by Molly's work here -- updated!

code-dot-org/apps/src/javalab/redux/editorRedux.ts

Lines 272 to 287 in d27cc42

const selectSources = (state: {javalabEditor: JavalabEditorState}) =>

state.javalabEditor.sources;

export const getSources = createSelector(selectSources, sources => {

const result: EditorFilesMap = {};

for (const key in sources) {

if (!sources[key].isValidation) {

result[key] = {

text: sources[key].text,

isVisible: sources[key].isVisible,

tabOrder: sources[key].tabOrder,

};

}

}

return result;

});

apps/src/aichat/views/AichatView.tsx

sanchitmalhotra126 · 2024-04-13T00:29:31Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  return property === 'botName' ? 'input' : 'textarea';
+};
+
+const renderPublishOkNotification = () => {


I don't exactly know what the performance implications are, but thoughts on just making these components instead of functions that create components every time the parent component is rendered?

hmm good q, I think I just had these returning HTML originally before refactoring :) I think I moved them out of the render function just for readability (and I just added some more logic to cover an edge case Alice identified here). Is there a difference between this and an inline ternary that returns a component on each render? Isn't the component created each time in that case as well, or is React smarter in that case and keeps them around or something?

Yeah, I think the key difference is using functions to render vs values? I don't think it matters a whole lot since these are small, but because they're static components, I was thinking we could benefit from memoizing them. I think we can either just make them static values if they're outside the main component (const publishOkNotification = <PublishStatus ... props />), or use useMemo inside the component (const publishOkNotification = useMemo(renderPublishOkNotification)))

Mentioned at #57949 (comment), but if a separate component, could use in other customization panels like 'Retrieval' (if retrieval context added/deleted but not updated yet).

I think this is already ready as a reusable component, just would need to be renamed from PublishStatus.

d'oh re: static value / no args, updated

Awesome - thanks!

sanchitmalhotra126 · 2024-04-13T00:31:08Z

apps/src/aichat/redux/aichatRedux.ts

+export const publishModel = createAsyncThunk(
+  'aichat/publishModelCard',
+  async (_, thunkAPI) => {
+    thunkAPI.dispatch(setHasPublished(true));
+    await updateAiCustomizationShared(thunkAPI);
+    thunkAPI.dispatch(setViewMode(ViewMode.PRESENTATION));
+  }
+);
+
+export const saveModelCard = createAsyncThunk(


nice refactoring! mind dropping some comments around how the code is organized between these various thunks and the shared function?

Cool refactoring - learned a lot here.

fisher-alice

Left a question about if the model card isreadonly but I think this is a solid checkpoint since I know you're planning a fast follow-up.
Learned a lot and thanks for the iteration and discussion!

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

fisher-alice · 2024-04-13T16:26:16Z

apps/src/aichat/redux/aichatRedux.ts

+);
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+const updateAiCustomizationShared = async (thunkAPI: any) => {


nit: maybe rename to updateAndSaveAiCustomizations or just saveAiCustomizations?

+1 on saveAiCustomizations

fisher-alice · 2024-04-13T16:43:50Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  const onPublish = useCallback(() => {
+    dispatch(updateAiCustomization());
+    dispatch(setHasPublished(true));
+    dispatch(setViewMode(ViewMode.PRESENTATION));


That would be great as a follow-up and +1 on using Denys's new Tabs component - thanks!

fisher-alice · 2024-04-13T16:47:55Z

apps/src/aichat/views/modelCustomization/PublishNotes.tsx

+  const onPublish = useCallback(() => {
+    dispatch(updateAiCustomization());
+    dispatch(setHasPublished(true));
+    dispatch(setViewMode(ViewMode.PRESENTATION));


Also related to comment below, that 'User View' remains displayed?
Not sure I'm following this part, happy to chat offline if easier!

Ah sorry. I think once we save hasPublished to sources, this will not be an issue when a user moves from level to level. I think I was referring to how when a model card has been published, the toggle remain visible.

fisher-alice · 2024-04-13T16:48:55Z

apps/src/aichat/redux/aichatRedux.ts

+export const publishModel = createAsyncThunk(
+  'aichat/publishModelCard',
+  async (_, thunkAPI) => {
+    thunkAPI.dispatch(setHasPublished(true));
+    await updateAiCustomizationShared(thunkAPI);
+    thunkAPI.dispatch(setViewMode(ViewMode.PRESENTATION));
+  }
+);
+
+export const saveModelCard = createAsyncThunk(


Cool refactoring - learned a lot here.

fisher-alice · 2024-04-15T18:07:17Z

apps/src/aichat/views/AichatView.tsx

+      !levelAichatSettings?.hidePresentationPanel &&
+      (hasPublished ||
+        (levelAichatSettings?.visibilities &&
+          isDisabled(levelAichatSettings.visibilities.modelCardInfo)))


Not sure if this is P0 - If levelbuilders mark visibility of modelCardInfo as readonly, then it is assumed that all of the fields in model card should be filled out. Maybe worth checking with Dan on this assumption or do levelbuilders need a reminder about this.

If this is a P0, we can add a levelbuilder-side check for this as well

I already did it, so I'll leave this for now (I think its a sensible default). We can clarify the finer points with levelbuilders / validate down the road

sanchitmalhotra126 · 2024-04-15T18:15:15Z

apps/src/aichat/redux/aichatRedux.ts

 };

 // THUNKS

 // This thunk saves a student's AI customizations using the Project Manager (ie, to S3 typically),
 // then does a comparison between the previous and current saved customizations in order to
 // output a message to the chat window with the list of customizations that were updated.
-export const updateAiCustomization = createAsyncThunk(
-  'aichat/updateAiCustomization',
+export const saveAiCustomization = createAsyncThunk(


very minor / optional - name this updateAiCustomizations to match "Update" button and keep the shared function just saveAiCustomizations?

Commented on this already but I think this would be more clear as well.

Ok you guys win, updated

😁 Thanks for iterating on this!

sanchitmalhotra126 · 2024-04-15T18:18:45Z

apps/src/aichat/views/AichatView.tsx

+      !levelAichatSettings?.hidePresentationPanel &&
+      (hasPublished ||
+        (levelAichatSettings?.visibilities &&
+          isDisabled(levelAichatSettings.visibilities.modelCardInfo)))


If this is a P0, we can add a levelbuilder-side check for this as well

bencodeorg added 5 commits April 9, 2024 16:03

Add examples and topics

3636a8c

Refactor

5f12660

Remove unneeded key

fba4bcf

Use design system Button

648e3fa

Refactor to use notification component, clean up

397c2da

Base automatically changed from ben/gen-ai-add-example-topics to staging April 11, 2024 15:02

bencodeorg added 5 commits April 11, 2024 08:19

Merge branch 'staging' into ben/gen-ai-publish-save-buttons

80d84ea

Clean up

51988fe

Move view mode state to redux, change mode on publish

e02d328

Add isPublished state, show most recently saved model card

2ef7371

Hide publish tab when no presentation view available

2a592a1

bencodeorg commented Apr 11, 2024

View reviewed changes

Clean up

6f8779c

bencodeorg commented Apr 11, 2024

View reviewed changes

apps/src/aichat/redux/aichatRedux.ts Show resolved Hide resolved

bencodeorg requested a review from a team April 11, 2024 20:49

fisher-alice approved these changes Apr 12, 2024

View reviewed changes

fisher-alice self-requested a review April 12, 2024 14:59

sanchitmalhotra126 reviewed Apr 12, 2024

View reviewed changes

bencodeorg added 2 commits April 12, 2024 13:28

Move selector for filled out model card to redux

6416f46

Refactor async thunk

81b265f

bencodeorg commented Apr 12, 2024

View reviewed changes

bencodeorg requested a review from sanchitmalhotra126 April 12, 2024 21:20

sanchitmalhotra126 reviewed Apr 13, 2024

View reviewed changes

fisher-alice approved these changes Apr 13, 2024

View reviewed changes

bencodeorg added 3 commits April 15, 2024 09:32

Handle readonly model card

7f8b29e

Rename shared function, simplify args

a180faa

Merge branch 'staging' into ben/gen-ai-publish-save-buttons

486a02c

bencodeorg requested a review from sanchitmalhotra126 April 15, 2024 17:51

Fix typos

c333591

fisher-alice reviewed Apr 15, 2024

View reviewed changes

sanchitmalhotra126 approved these changes Apr 15, 2024

View reviewed changes

Use preferred func name, static instead of func

c9e4c54

bencodeorg merged commit e5ecd41 into staging Apr 15, 2024
2 checks passed

bencodeorg deleted the ben/gen-ai-publish-save-buttons branch April 15, 2024 22:05

bencodeorg mentioned this pull request Apr 18, 2024

Gen AI lab: persist model card publish state, fix model list bug #58111

Merged

	extraReducers: builder => {
	builder.addCase(submitChatMessage.fulfilled, state => {
	state.isWaitingForChatResponse = false;
	});
	builder.addCase(submitChatMessage.rejected, (state, action) => {
	state.isWaitingForChatResponse = false;
	state.chatMessageError = true;
	console.error(action.error);
	});
	builder.addCase(submitChatMessage.pending, state => {
	state.isWaitingForChatResponse = true;
	});
	},
	});

	thunkAPI.dispatch(
	setPreviouslySavedAiCustomizations(trimmedCurrentAiCustomizations)
	);

	const changedProperties = findChangedProperties(
	previouslySavedAiCustomizations,
	trimmedCurrentAiCustomizations
	);
	changedProperties.forEach(property => {
	thunkAPI.dispatch(
	addChatMessage({
	id: 0,
	role: Role.MODEL_UPDATE,
	chatMessageText:
	AI_CUSTOMIZATIONS_LABELS[property as keyof AiCustomizations],
	status: Status.OK,
	timestamp: getCurrentTime(),
	})
	);
	});

	function setProjectAndLevelData(
	data: {
	levelProperties: LevelProperties;
	channel?: Channel;
	initialSources?: ProjectSources;
	},
	aborted: boolean,
	dispatch: ThunkDispatch<unknown, unknown, AnyAction>
	) {

	const selectSources = (state: {javalabEditor: JavalabEditorState}) =>
	state.javalabEditor.sources;

	export const getSources = createSelector(selectSources, sources => {
	const result: EditorFilesMap = {};
	for (const key in sources) {
	if (!sources[key].isValidation) {
	result[key] = {
	text: sources[key].text,
	isVisible: sources[key].isVisible,
	tabOrder: sources[key].tabOrder,
	};
	}
	}
	return result;
	});

Gen AI: separate "publish" and "save" buttons when filling out model card #57949

Gen AI: separate "publish" and "save" buttons when filling out model card #57949

Conversation

bencodeorg commented Apr 11, 2024 • edited

Warning!!

Description

Testing story

Follow-up work

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fisher-alice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fisher-alice Apr 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bencodeorg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanchitmalhotra126 Apr 15, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bencodeorg Apr 15, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanchitmalhotra126 Apr 13, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fisher-alice left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bencodeorg commented Apr 11, 2024 •

edited

fisher-alice Apr 13, 2024 •

edited

sanchitmalhotra126 Apr 15, 2024 •

edited

bencodeorg Apr 15, 2024 •

edited

sanchitmalhotra126 Apr 13, 2024 •

edited

fisher-alice left a comment •

edited