Skip to content

Conversation

@Atul9
Copy link

@Atul9 Atul9 commented Jun 18, 2018

closes #56

@etcook
Copy link

etcook commented Sep 27, 2018

Is this going to be merged in?

@iffyuva
Copy link
Member

iffyuva commented Sep 27, 2018

@etcook we need to test this out, it will take sometime. Can you help us test this if possible?

@etcook
Copy link

etcook commented Sep 27, 2018

@iffyuva sure - how can I help? Want to connect offline?

@etcook
Copy link

etcook commented Sep 29, 2018

@iffyuva I've done a bit of integration and testing. This commit does indeed fix the Rails 5 issue referenced in #56

I'll open up a new issue with my thoughts for discussion.

@PhilT
Copy link

PhilT commented Jun 7, 2019

Is this still an issue?

@weber-s
Copy link

weber-s commented Jan 9, 2020

Hello!

Is this branch going to be merged anytime soon? I have an application that rely on this gem, and I would like to update it to rails 5, so I'm looking forward the publication of this gem compatible for it :)

Thanks for the job anyway!

@Atul9 Atul9 merged commit 50fd1ae into master Jan 13, 2020
@Atul9
Copy link
Author

Atul9 commented Jan 14, 2020

Hi all, this PR is merged and I have published the gem to rubygems.org - https://rubygems.org/gems/invoicing/versions/1.1.0

@weber-s
Copy link

weber-s commented Jan 14, 2020

Thank you very much for the work!! (and the quick reply!!!)

@etcook
Copy link

etcook commented Jan 15, 2020

@Atul9 This might be a localized issue for me - I haven't done any testing, but catching my fork up to this release broke my app, and I wanted to put a quick note here just in case it's not just localized to me.

NameError: undefined local variable or method `currency_value_class_info' for #<Class:0x00005610905e6d10>
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/gems/activerecord-6.0.2.1/lib/active_record/dynamic_matchers.rb:22:in `method_missing'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/bundler/gems/invoicing-2aab0bdbba65/lib/invoicing/currency_value.rb:122:in `block in <module:CurrencyValue>'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.2.1/lib/active_support/concern.rb:122:in `class_eval'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/gems/activesupport-6.0.2.1/lib/active_support/concern.rb:122:in `append_features'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/bundler/gems/invoicing-2aab0bdbba65/lib/invoicing/class_info.rb:75:in `include'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/bundler/gems/invoicing-2aab0bdbba65/lib/invoicing/class_info.rb:75:in `acts_as'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/bundler/gems/invoicing-2aab0bdbba65/lib/invoicing/currency_value.rb:116:in `acts_as_currency_value'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/vendor/bundle/ruby/2.6.0/bundler/gems/invoicing-2aab0bdbba65/lib/invoicing/ledger_item.rb:315:in `acts_as_ledger_item'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/app/models/invoicing_ledger_item.rb:2:in `<class:InvoicingLedgerItem>'
       /tmp/build_321a9cace7dfa25e2030fa43705633ce/app/models/invoicing_ledger_item.rb:1:in `<main>'

@thegeorgeous thegeorgeous deleted the production-fix branch February 7, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in rails 5.2

7 participants