Implement json ipc #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far invoker use hastily put together gets/puts for exchanging messages between processes. Lets replace that with proper JSON based protocol.
I really like Thor's way of command line option parsing and hence replacing it.
Implement separate command classes for handling incoming JSON messages to Server and sending responses. This will give us much better flexibility in extending invoker.
I figured Yajl does blocking read in blocks of 8092 bytes and hence it will always block unless other end writes JSON and closes the socket. Lets implement proper JSON protocol for it.
Contributor
Author
There was a problem hiding this comment.
These I moved because we only need these things in forked process, that runs DNS server and load balancer. This greatly helped with loading time of Invoker.
Contributor
|
Got the following error while running I think |
Contributor
Author
|
Good catch @abasak . yeah that will require fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch does not implement any new features in Invoker But:
a. replaces Slop with Thor.
b. Implements JSON IPC for exchanging messages between processes and hence making it much more extensible.